Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Oct 2025 05:13:25 GMT
From:      Lexi Winter <ivy@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 0242d4c3aea4 - main - libc: Move NLS catalogues to the locales packages
Message-ID:  <202510050513.5955DPs1073331@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by ivy:

URL: https://cgit.FreeBSD.org/src/commit/?id=0242d4c3aea4b56ba76da440d1948d9e3d19ae87

commit 0242d4c3aea4b56ba76da440d1948d9e3d19ae87
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-10-05 05:03:21 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2025-10-05 05:12:54 +0000

    libc: Move NLS catalogues to the locales packages
    
    We don't want to put these in clibs (where libc is) since they are not
    critical to system operation.  Move them to locales, since anyone who
    is interested in translated versions of strerror() is going to have
    that installed anyway.
    
    While here, add some more documentation to bsd.nls.mk, particularly
    the NLSPACKAGE option.
    
    MFC after:      3 seconds
    Reviewed by:    manu, kib
    Sponsored by:   https://www.patreon.com/bsdivy
    Differential Revision:  https://reviews.freebsd.org/D52898
---
 lib/libc/nls/Makefile.inc | 5 +++++
 share/mk/bsd.nls.mk       | 9 +++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/libc/nls/Makefile.inc b/lib/libc/nls/Makefile.inc
index f26e04c187a5..c211026aba72 100644
--- a/lib/libc/nls/Makefile.inc
+++ b/lib/libc/nls/Makefile.inc
@@ -12,6 +12,11 @@ MAN+=	catclose.3 catgets.3 catopen.3
 #       for translators.
 
 NLSNAME=	libc
+# We don't want libc's NLS catalogues to be installed in the clibs package.
+# Put them in locales instead, since anyone interested in NLS will have
+# that installed.
+NLSPACKAGE=	locales
+
 NLS+=	be_BY.UTF-8
 NLS+=	ca_ES.ISO8859-1
 NLS+=	de_DE.ISO8859-1
diff --git a/share/mk/bsd.nls.mk b/share/mk/bsd.nls.mk
index bd13fe56679d..5a28e1cdd026 100644
--- a/share/mk/bsd.nls.mk
+++ b/share/mk/bsd.nls.mk
@@ -1,6 +1,8 @@
 #
-# This include file <bsd.nls.mk> handles building and installing Native
-# Language Support (NLS) catalogs
+# Handle building and installing Native Language Support (NLS) catalogs.
+# This is implemented using a <bsd.files.mk> files group called "NLS",
+# so any per-group options that bsd.files.mk supports can be used here
+# with the prefix "NLS".
 #
 # +++ variables +++
 #
@@ -17,6 +19,9 @@
 # NLSMODE	National Language Support files mode. [${NOBINMODE}]
 #
 # NLSOWN	National Language Support files owner. [${SHAREOWN}]
+#
+# NLSPACKAGE	Package to install the NLS files in.
+#		[${PACKAGE}, or "utilities" if not set]
 
 .if !target(__<bsd.init.mk>__)
 .error bsd.nls.mk cannot be included directly.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510050513.5955DPs1073331>