Date: Thu, 20 Aug 2009 11:04:31 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/usr.bin/fstat fstat.c zfs.c Message-ID: <200908201104.n7KB4sAJ019585@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
avg 2009-08-20 11:04:31 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_8)
usr.bin/fstat fstat.c zfs.c
Log:
SVN rev 196400 on 2009-08-20 11:04:31Z by avg
MFC 196399: fstat: fix fsid comparison when executed on systems with 64-bit long
This affects only fstat on zfs and devfs, only on 64-bit systems
and only when fsid is greater than 2^31 - 1.
When fstat examines a file via stat(2) it takes uint32_t st_dev
and assigns to (signed) (64-bit) long fsid, this results in
a positive value.
When fstat examines opened files it takes int32_t f_fsid.val[0]
and assigns to (signed) (64-bit) long fsid, this results in
a negative value.
So, while initially st_dev and f_fsid.val[0] have the same bit
values they get promoted to different 64-bit values because
of the signed-vs-unsigned difference.
A fix is to use "more natural" positive numbers by introducing
intermediate unsigned cast for f_fsid.val[0].
Reviewed by: jhb, lulf
Approved by: re (kib)
MFC after: 1 week (to stable/7)
Revision Changes Path
1.71.2.2 +1 -1 src/usr.bin/fstat/fstat.c
1.8.4.2 +1 -1 src/usr.bin/fstat/zfs.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908201104.n7KB4sAJ019585>