Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 25 Sep 2024 07:13:47 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c9c2452a2535 - main - unix tests: Skip random_eor_and_waitall unconditionally
Message-ID:  <202409250713.48P7Dl8t028710@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=c9c2452a25355db7d89bfc93fd9d50f46690949c

commit c9c2452a25355db7d89bfc93fd9d50f46690949c
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-09-21 12:41:06 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-09-25 11:44:14 +0000

    unix tests: Skip random_eor_and_waitall unconditionally
    
    This test always fails, I don't see any reason to make it conditional on
    the "CI" test parameter.
    
    There is at least one test bug here, we're using the wrong sysctl to
    obtain the receive buffer size, but fixing that is not sufficient.
    
    PR:             279354
    Reviewed by:    glebius
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D46726
---
 tests/sys/kern/unix_seqpacket_test.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/sys/kern/unix_seqpacket_test.c b/tests/sys/kern/unix_seqpacket_test.c
index ba3de0adb1e9..d142e228b036 100644
--- a/tests/sys/kern/unix_seqpacket_test.c
+++ b/tests/sys/kern/unix_seqpacket_test.c
@@ -1197,8 +1197,7 @@ ATF_TC_BODY(random_eor_and_waitall, tc)
 	size_t off;
 	int fd[2], eor;
 
-	if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false))
-		atf_tc_skip("https://bugs.freebsd.org/279354");
+	atf_tc_skip("https://bugs.freebsd.org/279354");
 
 	arc4random_buf(params.seed, sizeof(params.seed));
 	printf("Using seed:");
@@ -1210,7 +1209,7 @@ ATF_TC_BODY(random_eor_and_waitall, tc)
 	for (u_int i = 0; i < RANDOM_TESTSIZE / (u_int )sizeof(long); i++)
 		((long *)params.sendbuf)[i] = nrand48(&params.seed[0]);
 
-	ATF_REQUIRE(sysctlbyname("net.local.stream.recvspace",
+	ATF_REQUIRE(sysctlbyname("net.local.seqpacket.recvspace",
 	    &params.recvspace, &(size_t){sizeof(u_long)}, NULL, 0) != -1);
 	ATF_REQUIRE((recvbuf =
 	    malloc(RANDOM_RECVSIZE * params.recvspace)) != NULL);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409250713.48P7Dl8t028710>