Date: Sat, 13 Mar 2004 12:25:20 +0200 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: Tom Rhodes <trhodes@FreeBSD.ORG> Subject: Re: cvs commit: src/share/mk bsd.cpu.mk bsd.dep.mk bsd.lib.mk bsd.sys.mk src/sys/conf files kern.mk kern.pre.mk kmod.mk src/sys/dev/aic7xxx/aicasm Makefile Message-ID: <20040313102520.GA33766@ip.net.ua> In-Reply-To: <20040313105719.5e4e8765@Magellan.Leidinger.net> References: <200403122136.i2CLaCm9096276@repoman.freebsd.org> <20040312215649.GA4588@ip.net.ua> <20040313105719.5e4e8765@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Mar 13, 2004 at 10:57:19AM +0100, Alexander Leidinger wrote:
> On Fri, 12 Mar 2004 23:56:49 +0200
> Ruslan Ermilov <ru@freebsd.org> wrote:
>
> > > Index: src/share/mk/bsd.lib.mk
> > > diff -u src/share/mk/bsd.lib.mk:1.156 src/share/mk/bsd.lib.mk:1.157
> > > --- src/share/mk/bsd.lib.mk:1.156 Tue Jan 27 15:22:15 2004
> > > +++ src/share/mk/bsd.lib.mk Fri Mar 12 13:36:12 2004
> > [...]
> > > +.c.o:
> > > + ${CC} ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET}
> > > +
> > >
> > Please revert the addition of this, it's bogus and duplicated
> > what's already in sys.mk.
>
> Ooops... sorry. I think this bogus change crept in at the time you moved
> this part to sys.mk (at least I think you did something like this, and I
> forgot to review your change entirely).
>
OK. Tom will take care of this.
> > > -.endif !defined(INTERNALLIB)
> > > +.endif #!defined(INTERNALLIB)
> > >
> > Please revert this.
>
> Why? .endif doesn't take an argument and it serves as a comment. So why
> not make it explicit? I would agree with adding a space after the
> comment sign, but I don't understand why it should be reverted.
>
Because it has nothing to do with ICC support. Because other places
in share/mk spell it like this. Because I prefer it this way. ;)
Cheers,
--
Ruslan Ermilov
FreeBSD committer
ru@FreeBSD.org
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAUuGQUkv4P6juNwoRAjxyAKCEhgAPibH0i7+hyQA8+LlaQ6ZzoACfdX7b
qyps7aeAO8R67pSN0LS87y8=
=9Ow8
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040313102520.GA33766>