Date: Mon, 07 Dec 2020 13:50:56 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: yuripv@yuripv.dev Cc: thomas.munro@gmail.com, bapt@freebsd.org, hackers@freebsd.org Subject: Re: locale-related review, wcwidth() data Message-ID: <20201207.135056.445534109566789594.hrs@FreeBSD.org> In-Reply-To: <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev> References: <20201204133111.uyu55cl7zgll4vk2@ivaldir.net> <CA%2BhUKGK6FMef7jU5qnCVnaeN8TFJ8y_dUfuOdVfSxAkJYFqnFA@mail.gmail.com> <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Yuri Pankov <yuripv@yuripv.dev> wrote
in <14fbfd11-a5fa-4e7e-422c-33738364c58d@yuripv.dev>:
yu> Thomas Munro wrote:
yu> > On Sat, Dec 5, 2020 at 2:31 AM Baptiste Daroussin <bapt@freebsd.org>
yu> > wrote:
yu> >> I do like what I see here, the only reason I haven't review is that I
yu> >> can't
yu> >> test, since the last modification from hrs@ in the locale generation
yu> >> tools each
yu> >> time I try to regenerate the locales it fails.
yu> > During install? I noticed that too but wasn't sure of the correct
yu> > fix, perhaps:
yu> > diff --git a/tools/tools/locale/Makefile b/tools/tools/locale/Makefile
yu> > index 76fff6acb17..b6ae2feadac 100644
yu> > --- a/tools/tools/locale/Makefile
yu> > +++ b/tools/tools/locale/Makefile
yu> > @@ -95,7 +95,7 @@ install: install-${t}
yu> > install-${t}:
yu> > cd ${LOCALESRCDIR}/${t} && \
yu> > rm -f Makefile *.src && \
yu> > - install -c ${t}/* ${LOCALESRCDIR}/${t}
yu> > + install -c ${.OBJDIR}/${t}/* ${LOCALESRCDIR}/${t}
yu> > . endif
yu> > .endfor
yu>
yu> Makes sense.
yu>
yu> BTW, to test what is in this review, you don't need the install target
yu> -- new 'width' target depends only on cldr posix data itself, and
yu> modifies etc/final-maps/widths.txt directly.
Sorry for keeping silence about the report. I fixed it in r368404.
-- Hiroki
----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
iMoEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCX820sBAcaHJzQGZyZWVi
c2Qub3JnAAoJENuwfcZvH3N/qWUCCQG4Y34bepjAvUbW/h7swRh7efUT/82q8BmC
aFjJjUUQdJUJRp0z2m0zN8Jy6J3sOkyLuIEVqcnVTG6WHi98+PD7QAIJAWT2Og52
7dDoL0MaFOQHxtnMpc9vdRIUw92MherZBwQiddtP/kRCxz/h+P++fbJd6LzMeMLE
16krBNNb5Xrroa6A
=ulMB
-----END PGP SIGNATURE-----
----Security_Multipart(Mon_Dec__7_13_50_56_2020_585)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201207.135056.445534109566789594.hrs>