Date: Wed, 5 Jan 2005 15:12:53 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: freebsd-current@freebsd.org, Julian Elischer <julian@freebsd.org> Subject: RFC: Inverse KASSERT in sys/dev/usb/ohci.c:1.150 ? Message-ID: <20050105131253.GA12430@orion.daedalusnetworks.priv>
next in thread | raw e-mail | index | archive | help
The KASSERT that replaces an explicit if conditional in ohci.c:1.150
causes a panic here when I try to use my USB flash disk:
% -#ifdef DIAGNOSTIC
% - if (curlen == 0)
% - panic("ohci_alloc_std: curlen == 0");
% -#endif
% + KASSERT ((curlen == 0), ("ohci_alloc_std: curlen == 0"));
Shouldn't the KASSERT expression have inverse logic, i.e.:
KASSERT((curlen != 0), ("ohci_alloc_std: curlen == 0"));
- Giorgos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050105131253.GA12430>