Date: Wed, 22 Mar 2017 14:20:09 +0000 From: deborah.perry@datadynamicsit.biz To: freebsd-net@freebsd.org Subject: Re:Embedded Systems Users List Message-ID: <94eb2c03334e3b79ab054b527547@google.com>
next in thread | raw e-mail | index | archive | help
DQoNCkhpLA0KDQpBIHF1aWNrIGZvbGxvdyB1cCB0byBrbm93IGlmIHlvdSB3b3VsZCBiZSBpbnRl cmVzdGVkIGluICpFbWJlZGRlZCBTeXN0ZW1zKg0KVXNlcnMgbGlzdCBmb3IgeW91ciBtYXJrZXRp bmcgY2FtcGFpZ24/DQoNCipMaXN0IENvbnRhaW5zOiogTmFtZSwgQ29tcGFueSdzIE5hbWUsIFBo b25lIE51bWJlciwgRmF4IE51bWJlciwgSm9iIFRpdGxlLA0KRW1haWwgYWRkcmVzcywgQ29tcGxl dGUgTWFpbGluZyBBZGRyZXNzLCBTSUMgY29kZSwgQ29tcGFueSByZXZlbnVlLCBzaXplLA0KV2Vi IGFkZHJlc3MgZXRjLg0KDQpTcGVjaWFsdGllczogVkxTSSwgTWljcm8gQ29udHJvbGxlciwgR2Vu ZXJhbCBjb21wdXRpbmcgc3lzdGVtcywgTmV0d29ya2luZywNClBMQywgV2ViIERldmVsb3BtZW50 DQoNCg0KDQpMZXQgbWUga25vdyB5b3VyIHRob3VnaHRzIG9yIHBhc3Mgb24gdGhlIG1lc3NhZ2Ug dG8gdGhlIHJpZ2h0IHBlcnNvbiBpbg0KeW91ciBjb21wYW55Lg0KDQoNCklmIHlvdSBhcmUgbG9v a2luZyBmb3IgYW55IG90aGVyIHRlY2hub2xvZ2llcyBwbGVhc2UgbGV0IG1lIGtub3cgeW91cg0K Y3JpdGVyaWEgSSB3aWxsIGdldCBiYWNrIHRvIHlvdSB3aXRoIHRoZSBzYW1lIHRhcmdldC4NCg0K VGhhbmtzICYgcmVnYXJkcywNCkRlYm9yYWggUGVycnkNCk1hcmtldGluZyBBbmFseXN0DQoNCklm IHlvdSBkb27igJl0IHdhbnQgdG8gcmVjZWl2ZSBhbnkgbWVzc2FnZSBmcm9tIHVzIHRoZW4gcGxl YXNlIHR5cGUg4oCcT1BUIE9VVOKAnQ0KaW4gdGhlIFN1YmplY3QgTGluZS4NCg== From owner-freebsd-net@freebsd.org Wed Mar 22 17:18:50 2017 Return-Path: <owner-freebsd-net@freebsd.org> Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CED5D1856C for <freebsd-net@mailman.ysv.freebsd.org>; Wed, 22 Mar 2017 17:18:50 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: from mail-qk0-x231.google.com (mail-qk0-x231.google.com [IPv6:2607:f8b0:400d:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 351BC1175; Wed, 22 Mar 2017 17:18:50 +0000 (UTC) (envelope-from ozkan.kirik@gmail.com) Received: by mail-qk0-x231.google.com with SMTP id p22so22008418qka.3; Wed, 22 Mar 2017 10:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xEjOUJ2Uul4pLhxWeF8A35j67wwiZ0j5aj9LaSh0g0s=; b=bdj9BjoIxJ64yN34ipwdb0i3ye3Os92BeSsElV/BZnwoJp9EyhHk5aaL41ie3FI1mF a3KkhJv8tgkZt0KQAmgryD/o/gqZP8/YBvLJ6nL1K3dafCAHDC1aUfSJt/biHHL6xjgi iAwpiQ0IkcYVY2OafAeoP7oGgZq/byUZ60+el5FTKsoTvfU2EMBccLuoLrCfYrhYPNCt zfXiLVArhhs7FLwTr8qzAe7vjntMdzswmaIr6FR4JCxQD0o/LLfKMuygObA2XT5wq5CF 7Sv5lsp4PAwN5k19isYs74JU91dzije8GDkmK2aVMssMy80JH9SrYVa1lkiPqnlaVi6y 9L9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xEjOUJ2Uul4pLhxWeF8A35j67wwiZ0j5aj9LaSh0g0s=; b=FCqEygt9d/bOFSpzZOz8mJYJp0itIjsQsWV/ZYaWcgdSTSYH0URwkF3QFEnAYBalj4 8Uuy5v3zeLyoO1rtMhoa5XK7U/bZN1BspgnZgPFUEAa98lr6mKeTM8ZSkn39OvzCjujY 5RN0ldtAVDISvLUtTb0HsXXtwdcbYj7taAw8btMH07IqN7cS+QIRlcNT9EDRXY0Lvtmt +VP2FvprkVxGmV1UQlGQOoV+DKbSJKaFjztLCQb1TUcOsjttozz5gkdBwazPupK9+RZM 75M5NRruGRSpzRKLb7dLs99z3tP+JClFm0iAlkpTReBAXFXV2Ap9/UBIttvmiBC+h0Mk 6kzg== X-Gm-Message-State: AFeK/H3/OjbIrY6JAZBLN+IlBIXfzy+EH6DCyCY0THtzEUS3aMa8vaJ0lVpgLCJiXPfKqrhx2GTWWnVgLhdU5Q== X-Received: by 10.55.131.68 with SMTP id f65mr36471345qkd.1.1490203129064; Wed, 22 Mar 2017 10:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.179.135 with HTTP; Wed, 22 Mar 2017 10:18:48 -0700 (PDT) In-Reply-To: <CAPBZQG0oUHamfmvZxk8_LaPG_+hTbPTuvX4h7Y9osrsvcH1L3g@mail.gmail.com> References: <CAAcX-AFJ4mmFQt2k3gdsG4c8g3d-ypzSFpypQLQF_3Jdw0W3ew@mail.gmail.com> <CAPBZQG0oUHamfmvZxk8_LaPG_+hTbPTuvX4h7Y9osrsvcH1L3g@mail.gmail.com> From: =?UTF-8?B?w5Z6a2FuIEtJUklL?= <ozkan.kirik@gmail.com> Date: Wed, 22 Mar 2017 20:18:48 +0300 Message-ID: <CAAcX-AFcnwAMCBcaFVYBBAGJ=hV-8P8zoP+xPj6T9i4eX1UFEA@mail.gmail.com> Subject: Re: if_epair altq support problem To: =?UTF-8?Q?Ermal_Lu=C3=A7i?= <eri@freebsd.org> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>; List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 22 Mar 2017 17:18:50 -0000 Thank You Ermal ! It works perfectly, can you commit this patch to 11.0 RELENG and MFC to 10.3 RELENG ? Regards On Wed, Mar 22, 2017 at 6:59 AM, Ermal Lu=C3=A7i <eri@freebsd.org> wrote: > > > On Tue, Mar 21, 2017 at 5:26 AM, =C3=96zkan KIRIK <ozkan.kirik@gmail.com> > wrote: > >> Hello, >> >> I sent this email also to freebsd-pf list. But I think that the main >> problem is belongs to sys/net/if_epair.c. >> >> I'm using FreeBSD 10.3-p17 amd64. epair pseudo device is listed as >> supperted deviced at the Man page of altq(4). >> From man page of altq : >> >> *SUPPORTED DEVICES <https://www.freebsd.org/cgi/man.cgi?query=3Daltq#end= >* >> >> The driver modifications described in altq(9) >> <https://www.freebsd.org/cgi/man.cgi?query=3Daltq&sektion=3D9&ap >> ropos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports> >> are required to use a cer- >> tain network card with *ALTQ*. They have been applied to the >> following >> hardware drivers: ae(4) >> <https://www.freebsd.org/cgi/man.cgi?query=3Dae&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> age(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dage&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> alc(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dalc&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> ale(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dale&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> an(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dan&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> ath(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dath&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> aue(4) <https://www.freebsd.org/cgi/man.cgi?query=3Daue&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> axe(4) <https://www.freebsd.org/cgi/man.cgi?query=3Daxe&sektion=3D4= &apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> bce(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dbce&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> bfe(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dbfe&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> bge(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dbge&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> bxe(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dbxe&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> cas(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dcas&sektion=3D4&apr >> opos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> cxgbe(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dcxgbe&sektion=3D4&= a >> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> dc(4) <https://www.freebsd.org/cgi/man.cgi?query=3Ddc&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> de(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dde&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> ed(4) <https://www.freebsd.org/cgi/man.cgi?query=3Ded&sektion=3D4&a= pro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> em(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dem&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> ep(4) <https://www.freebsd.org/cgi/man.cgi?query=3Dep&sektion=3D4&apro >> pos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> epair(4) <https://www.freebsd.org/cgi/man.cgi?query=3Depair&sektion=3D4&= a >> propos=3D0&manpath=3DFreeBSD+11.0-RELEASE+and+Ports>, >> >> .... >> >> But while trying to use it the system says that it's not suppoerted. I >> tried on FreeBSD 11 also. The output is below: >> >> pf.conf : >> altq on epair0b hfsc bandwidth 1Mb queue { ftp, ssh, icmp, other } >> queue ftp bandwidth 30% priority 0 hfsc (upperlimit 99%) >> queue ssh bandwidth 30% priority 2 hfsc (upperlimit 99%) >> queue icmp bandwidth 10% priority 2 hfsc (upperlimit 99%) >> queue other bandwidth 30% priority 1 hfsc (default upperlimit 99%) >> >> >> # ifconfig epair0 create >> # ifconfig epair0a up >> # ifconfig epair0b up >> # pfctl -f pf.conf >> pfctl: epair0b: driver does not support altq >> >> # sysctl -a | grep ALTQ >> options ALTQ_NOPCC >> options ALTQ_PRIQ >> options ALTQ_CDNR >> options ALTQ_HFSC >> options ALTQ_RIO >> options ALTQ_RED >> options ALTQ_CBQ >> options ALTQ >> >> >> I have a look on /usr/src/sys/net/if_epair.c, and found the ALTQ section= : >> >> 514 #ifdef ALTQ >> 515 /* Support ALTQ via the clasic if_start() path. */ >> 516 IF_LOCK(&ifp->if_snd); >> 517 if (ALTQ_IS_ENABLED(&ifp->if_snd)) { >> 518 ALTQ_ENQUEUE(&ifp->if_snd, m, NULL, error); >> 519 if (error) >> 520 ifp->if_snd.ifq_drops++; >> 521 IF_UNLOCK(&ifp->if_snd); >> 522 if (!error) { >> 523 ifp->if_obytes +=3D len; >> 524 if (mflags & (M_BCAST|M_MCAST)) >> 525 ifp->if_omcasts++; >> 526 >> 527 if ((ifp->if_drv_flags & IFF_DRV_OACTIVE) = =3D=3D >> 0) >> 528 epair_start_locked(ifp); >> 529 else >> 530 (void)epair_add_ifp_for_drain >> ing(ifp); >> 531 } >> 532 return (error); >> 533 } >> 534 IF_UNLOCK(&ifp->if_snd); >> 535 #endif >> >> > > Just apply manually this patch to make it work. > > diff --git a/sys/net/if_epair.c b/sys/net/if_epair.c > index 540f06c..04733a5 100644 > --- a/sys/net/if_epair.c > +++ b/sys/net/if_epair.c > @@ -827,9 +827,11 @@ epair_clone_create(struct if_clone *ifc, char *name, > size_t len, caddr_t params) > ifp->if_capabilities =3D IFCAP_VLAN_MTU; > ifp->if_capenable =3D IFCAP_VLAN_MTU; > ifp->if_start =3D epair_start; > + if_setstartfn(ifp, epair_start); > + if_setsendqlen(ifp, ifqmaxlen); > + if_setsendqready(ifp); > ifp->if_ioctl =3D epair_ioctl; > ifp->if_init =3D epair_init; > - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; > /* Assign a hopefully unique, locally administered etheraddr. */ > eaddr[0] =3D 0x02; > eaddr[3] =3D (ifp->if_index >> 8) & 0xff; > @@ -852,10 +854,11 @@ epair_clone_create(struct if_clone *ifc, char *name= , > size_t len, caddr_t params) > ifp->if_flags =3D IFF_BROADCAST | IFF_SIMPLEX | IFF_MULTICAST; > ifp->if_capabilities =3D IFCAP_VLAN_MTU; > ifp->if_capenable =3D IFCAP_VLAN_MTU; > - ifp->if_start =3D epair_start; > + if_setstartfn(ifp, epair_start); > + if_setsendqlen(ifp, ifqmaxlen); > + if_setsendqready(ifp); > ifp->if_ioctl =3D epair_ioctl; > ifp->if_init =3D epair_init; > - ifp->if_snd.ifq_maxlen =3D ifqmaxlen; > /* We need to play some tricks here for the second interface. */ > strlcpy(name, epairname, len); > error =3D if_clone_create(name, len, (caddr_t)scb); > > > > > >> I have no idea that why it says that it doesn't support altq altough the >> source code contains ALTQ section. >> >> >> Regards >> =C3=96zkan KIRIK >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > > > > > -- > Ermal >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?94eb2c03334e3b79ab054b527547>