Date: Sat, 4 Nov 2006 20:54:38 +0000 (UTC) From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_tap.c Message-ID: <200611042054.kA4KscGZ047063@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
csjp 2006-11-04 20:54:38 UTC
FreeBSD src repository
Modified files:
sys/net if_tap.c
Log:
Currently, we initialize "error" to zero when it's declared, then
we never initialize it to anything else. However, in the case that
m_uiotombuf fails, we return error (effectively reporting success).
This appears to be a relic of an older revision of this file, where
"error" used to be doing something useful. (See revision 1.1, where
error is used in a loop with uiomove() instead of using m_uiotomubf).
So instead on unconditionally reporting success in the case there is
a failure in m_uiotombuf, explicitly return ENOBUFS. While we are
here, garbage collect the error variable since it's no longer required.
MFC after: 2 weeks
Revision Changes Path
1.65 +1 -2 src/sys/net/if_tap.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611042054.kA4KscGZ047063>