Date: Thu, 15 Jul 2021 19:06:52 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Guido Falsi <madpilot@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: dc9bf7d64926 - main - net/asterisk*: Add aarch64 support Message-ID: <YPBrLBa%2BrGGt/aoH@KGPE-D16> In-Reply-To: <YPBpeWTJvGwMv1FL@FreeBSD.org> References: <202107141033.16EAX60T044972@gitrepo.freebsd.org> <YO%2BYP1TDjq6MruvC@FreeBSD.org> <81bc6b76-7b74-9990-d7dc-54ca14b0ee4f@FreeBSD.org> <YPBpeWTJvGwMv1FL@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 21-07-15 16:59:37, Alexey Dokuchaev wrote: > On Thu, Jul 15, 2021 at 04:38:53PM +0200, Guido Falsi wrote: > > On 15/07/21 04:06, Alexey Dokuchaev wrote: > > > ... > > > I think ONLY_FOR_ARCHS here clearly outlived its purpose and can just > > > be removed. It arguably misses MIPS, but we aren't promising much for > > > that tier anyways, and this harness just gets in the way of those who > > > know that they're doing. After all, there shouldn't be anything > > > inherently architecture-specific about the telephony toolkit, but even > > > if there is, individual BROKEN_$arch would be more appropriate. > > > > The fact that mips is not included is exactly the reason I did not > > remove ONLY_FOR_ARCHS. > > > > If what you say is the general consensus I'll be quite happy to get rid > > of it. > > You'd likely not get general consensus as most people don't care. :-) > > > I guess this compiler mix situation is not an issue anymore. > > Right. I think it's generally bad idea to prematurely restrict software > to certain arches unless it's clearly arch-specific (e.g. comes only in > binary precompiled form or uses asm code). New arches appear frequently > (e.g. powerpc64le, riscv64) and some go away as well (ia64, sparc64), it > just does not look feasible to maintain those ONLY_FOR_ARCHS lists so > they'd always reflect the reality. This is the reason I prefer NOT_FOR_ARCHS - it doesn't require any intervention after adding new architectures. > > Even if one's port does break on MIPS, one should get a notice from the > build cluster and either fix it, or mark is as BROKEN_$arch, rather than > keep ONLY_FOR_ARCHS which would only get amended, causing needless repo > churn, upon every next time someone discovers that it builds and works > on their architecture of interest. > > ./danfe [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmDwaywACgkQelmbhSCD nJ219g/9HORv0PzbLgM6LvgVE9ymxyHRb4AA5nXj9rJazTbyxcMScpcXNv/pA6wj 0sGCER2EAN2vkbURbX4LxIUrfh1CD8y4hbX6okpTmt2/8M5XO0VzBAJlcz9dFUlV GIh/+bHuahFtNYnV2TGNyH+XF8XVI+bTPOOa8Ly+9XIVnYRRj3TfdDvtEUfqSTp/ nbHeXu9YQLNL1uP7D1WNSfHMLstdd6AG1oSMLFdOsCDfi3+kuqPhGVpNOGmeTfAi 3FKr/rpcc2K13W5sOAD1nF/gNRaXN1HU/LTODRBgGuLaRuFAQ8MfnqgOfJsiCl73 CvYx6pjixH9Yt6gXBGHTUN/+eQNkFw0jPzwh5bMq3V9P0iUu34BI2Yv14bo0Nq9E oj6ZNAsSTPIxSyGtoP/L0JJfou02XyoCGL7YTT88PS85Z93dYUSSU3qBHGCmOox5 EV04xUeuwE0WVTpc1CaREOI9dS+nVLf6v99AWuSu2lPYAbb4eaI+wOr+3ehpBcAW 2qT1bViS3rcxRaBJ52B764VornhGEfbnISFs/8EM+iCILtl/FLYIeIvZqNdqzIIp f3XXehXUbH0udvZe+MNRotJmE/NBHOJld9nrxQ2suI5sEU4fvP6PPKAUxfFg+FLN N85dHHGrfq2i4cdzM9OTxp/SFUCNWwSbRXMzBno0IFwA5OpIG9g= =A83X -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YPBrLBa%2BrGGt/aoH>