Date: Fri, 23 Mar 2018 02:45:09 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r331413 - head/sys/dev/efidev Message-ID: <201803230245.w2N2j9lt085680@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans Date: Fri Mar 23 02:45:09 2018 New Revision: 331413 URL: https://svnweb.freebsd.org/changeset/base/331413 Log: efidev: Drop a quick note in about efi_cfgtbl/efi_runtime There's no real annotation for it, so it's not immediately obvious to the unfamiliar that these pointers are to locations in the EFI runtime map unlike the system table pointer immediately above them. Modified: head/sys/dev/efidev/efirt.c Modified: head/sys/dev/efidev/efirt.c ============================================================================== --- head/sys/dev/efidev/efirt.c Fri Mar 23 02:38:31 2018 (r331412) +++ head/sys/dev/efidev/efirt.c Fri Mar 23 02:45:09 2018 (r331413) @@ -57,6 +57,11 @@ __FBSDID("$FreeBSD$"); #include <vm/vm_map.h> static struct efi_systbl *efi_systbl; +/* + * The following pointers point to tables in the EFI runtime service data pages. + * Care should be taken to make sure that we've properly entered the EFI runtime + * environment (efi_enter()) before dereferencing them. + */ static struct efi_cfgtbl *efi_cfgtbl; static struct efi_rt *efi_runtime;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803230245.w2N2j9lt085680>