Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Nov 2021 22:43:20 GMT
From:      Peter Grehan <grehan@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: a4c22552b8c4 - stable/13 - igc: correctly update RCTL when changing multicast filters.
Message-ID:  <202111122243.1ACMhKGj035533@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by grehan:

URL: https://cgit.FreeBSD.org/src/commit/?id=a4c22552b8c4e73d3d801cca98caa6fb771b1920

commit a4c22552b8c4e73d3d801cca98caa6fb771b1920
Author:     Peter Grehan <grehan@FreeBSD.org>
AuthorDate: 2021-10-11 17:49:01 +0000
Commit:     Peter Grehan <grehan@FreeBSD.org>
CommitDate: 2021-11-12 20:44:21 +0000

    igc: correctly update RCTL when changing multicast filters.
    
    Fix clearing of bits in RCTL for the non-bpf/non-allmulti case.
    Update RCTL after modifying the multicast filter registers as per
    the Linux driver.
    
    This fixes LACP on igc interfaces, where incoming LACP multicasti
    control packets were being dropped.
    
    Obtained from:  Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit 5a3eb6207a353c3a18da8abcf00a2d75276dd29e)
---
 sys/dev/igc/if_igc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c
index 6d94a7c223c7..436493185d5c 100644
--- a/sys/dev/igc/if_igc.c
+++ b/sys/dev/igc/if_igc.c
@@ -1172,12 +1172,12 @@ igc_if_multi_set(if_ctx_t ctx)
                 reg_rctl |= IGC_RCTL_MPE;
 		reg_rctl &= ~IGC_RCTL_UPE;
         } else
-		reg_rctl = ~(IGC_RCTL_UPE | IGC_RCTL_MPE);
-
-	IGC_WRITE_REG(&adapter->hw, IGC_RCTL, reg_rctl);
+		reg_rctl &= ~(IGC_RCTL_UPE | IGC_RCTL_MPE);
 
 	if (mcnt < MAX_NUM_MULTICAST_ADDRESSES)
 		igc_update_mc_addr_list(&adapter->hw, mta, mcnt);
+
+	IGC_WRITE_REG(&adapter->hw, IGC_RCTL, reg_rctl);
 }
 
 /*********************************************************************



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202111122243.1ACMhKGj035533>