Date: Thu, 25 Jan 2007 22:33:10 +0100 From: Max Laier <max@love2party.net> To: freebsd-net@freebsd.org Cc: "Bruce M. Simpson" <bms@freebsd.org>, Robert Watson <rwatson@freebsd.org> Subject: Re: rev. 1.94 of netinet/in.c broke CARP Message-ID: <200701252233.17309.max@love2party.net> In-Reply-To: <20070125212310.GG7922@cell.sick.ru> References: <20070125162422.GA7922@bestcom.ru> <20070125203807.S13293@fledge.watson.org> <20070125212310.GG7922@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1765310.oDHRGgHRZ9 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 25 January 2007 22:23, Gleb Smirnoff wrote: > On Thu, Jan 25, 2007 at 08:40:52PM +0000, Robert Watson wrote: > R> Architecturally, the right fix is that CARP needs to have a handler > for R> ifnet destruction that always runs before the multicast address > garbage R> collection. I'm pretty preoccupied for the next few days due > to an R> impending paper deadline, so can't investigate further > currently, but one R> way or the other that ordering dependency needs > to be expressed. If done R> properly, CARP will always have released > its multicast address before they R> are forceably removed. Having the > reference count is good too, but what I R> describe should be > sufficient regardless of the refcount. > > This means removing usage of EVENTHANDLER(9) and going back to > exporting carp_ifdetach() and calling it directly from if_detach(). > This is back out revision 1.255 of net/if.c. Not sure what is a right > way... > > I am worried about that CARP is not the only subsystem in kernel > that can join a multicast group on an ifnet, and keep a pointer > to the multicast instance. pfsync might, but from a quick glance at this thread and code it seems=20 non-related. I'll look more closely later. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart1765310.oDHRGgHRZ9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQBFuSIdXyyEoT62BG0RAvYZAJ4sxF8FIAc8ujb9g/DQjaNTA39DWgCbBzR+ WiIpdnP9NU2kGp0noOIQ0mA= =ZF/B -----END PGP SIGNATURE----- --nextPart1765310.oDHRGgHRZ9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701252233.17309.max>