Date: Mon, 2 Aug 2021 12:15:55 -0400 From: Alexander Motin <mav@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 74f80bc1af2f - main - coretemp(4): Switch to smp_rendezvous_cpus(). Message-ID: <5b8b9ee4-4c90-ed32-de37-9d03fd812550@FreeBSD.org> In-Reply-To: <YQVGn7VhKstcGndr@kib.kiev.ua> References: <202107300326.16U3QGHR070204@gitrepo.freebsd.org> <YQVGn7VhKstcGndr@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31.07.2021 08:48, Konstantin Belousov wrote:
>> +static void
>> +coretemp_wrmsr(void *arg)
>> +{
>> + struct coretemp_args *args = arg;
>> +
>> + wrmsr(args->msr, args->val);
>> +}
> We have x86_msr_op(). It covers coretemp_wrmsr(), and with slight
> change of the interface would also handle the functionality of
> coretemp_rdmsr().
As I see x86_msr_op() is tuned for MSR modification on all CPUs, while
this code touches one CPU at a time.
--
Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5b8b9ee4-4c90-ed32-de37-9d03fd812550>