Date: Wed, 5 Jan 2005 14:28:00 +0100 From: Maxime Henrion <mux@freebsd.org> To: Giorgos Keramidas <keramida@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: RFC: Inverse KASSERT in sys/dev/usb/ohci.c:1.150 ? Message-ID: <20050105132800.GE63028@elvis.mu.org> In-Reply-To: <20050105131253.GA12430@orion.daedalusnetworks.priv> References: <20050105131253.GA12430@orion.daedalusnetworks.priv>
next in thread | previous in thread | raw e-mail | index | archive | help
Giorgos Keramidas wrote:
> The KASSERT that replaces an explicit if conditional in ohci.c:1.150
> causes a panic here when I try to use my USB flash disk:
>
> % -#ifdef DIAGNOSTIC
> % - if (curlen == 0)
> % - panic("ohci_alloc_std: curlen == 0");
> % -#endif
> % + KASSERT ((curlen == 0), ("ohci_alloc_std: curlen == 0"));
>
> Shouldn't the KASSERT expression have inverse logic, i.e.:
>
> KASSERT((curlen != 0), ("ohci_alloc_std: curlen == 0"));
Yes, it indeed should.
Cheers,
Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050105132800.GE63028>