Date: Tue, 4 Mar 1997 16:29:05 +1030 (CST) From: Michael Smith <msmith@atrad.adelaide.edu.au> To: jlemon@americantv.com (Jonathan Lemon) Cc: msmith@atrad.adelaide.edu.au, proff@iq.org, hackers@FreeBSD.ORG Subject: Re: xemacs crashes kernel Message-ID: <199703040559.QAA11070@genesis.atrad.adelaide.edu.au> In-Reply-To: <19970303235057.26399@right.PCS> from Jonathan Lemon at "Mar 3, 97 11:50:57 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Jonathan Lemon stands accused of saying: > > I changed the fsync code to read: > > error = VOP_FSYNC(vp, fp->f_cred, > (vp->v_mount && (vp->v_mount->mnt_flag & MNT_ASYNC)) ? > MNT_NOWAIT : MNT_WAIT, p); > > And it doesn't crash the kernel any more. I'm not sure if this is > the right fix or not. Julian - you might want to try this as well. It might be. The MFS appears to be the culprit, courtesy of this in mfs_vfsops.c/mfs_mount() : err = getnewvnode(VT_MFS, (struct mount *)0, mfs_vnodeop_p, &devvp); Every other filesystem mount routine passes it's (mp) arg here, but this sucker passes 0. Filesystem people, Is This a Bug? (I can't do the raspy voice while typing 8) > Jonathan -- ]] Mike Smith, Software Engineer msmith@gsoft.com.au [[ ]] Genesis Software genesis@gsoft.com.au [[ ]] High-speed data acquisition and (GSM mobile) 0411-222-496 [[ ]] realtime instrument control. (ph) +61-8-8267-3493 [[ ]] Unix hardware collector. "Where are your PEZ?" The Tick [[
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703040559.QAA11070>