Skip site navigation (1)Skip section navigation (2)
Date:      14 Aug 1997 11:22:01 GMT
From:      nnd@itfs.nsk.su
To:        bugs@freebsd.org
Subject:   Re: bin/4291: /usr/bin/make - inconsistent -j<n> flag parsing
Message-ID:  <5supop$an9@news.itfs.nsk.su>
References:  <199708140439.WAA26525@Ilsa.StevesCafe.com>

index | next in thread | previous in thread | raw e-mail

Steve Passe <smp@csn.net> wrote:

> From my first look at the source I concluded that all the '-' opts would
> have to be first as getopts bails out on the first non '-' string found.
> However, closer examination shows that indeed it goes back for additional
> passes to deal with this issue. So there is a simpler fix that I will commit
> in a few minutes.

	Unfortunally (due to my not so "precise" description
of a problem ;-) your "sipler fix" is unsufficient.

	Second case in "How-To-Repeat" section of my PR must be:

2)
	setenv MAKEFLAGS "-j12"
	make all

will set "compat mode", whereas

	setenv MAKEFLAGS ""
	make -j12 all

will work in "parallel" mode.

	This is definitely a bug because all other '-' flags
sets corresponding variables independetly of their source -
form MAKEFLAGS environment variable or from command line
arguments.

	So I propose to commit my original fix and close
this PR, or I can send other PR with new patch (which
will be mostly the same as you only shift the block of
lines in your patch).

	N.Dudorov



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5supop$an9>