Date: Mon, 18 Jan 2010 16:29:35 GMT From: Greg Larkin <glarkin@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/142939: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN Message-ID: <201001181629.o0IGTZol076374@www.freebsd.org> Resent-Message-ID: <201001181630.o0IGU8ax026809@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 142939 >Category: ports >Synopsis: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Jan 18 16:30:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Greg Larkin >Release: 7.0-RELEASE >Organization: The FreeBSD Project >Environment: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59: 52 UTC 2008 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: sysutils/xfce4-netload-plugin was marked BROKEN on 8.0 (OSVERSION >= 800000) because of a compile error resulting from a missing net/if_ppp.h include file. net/if_ppp.h was removed for OSVERSION >= 800045, so adjust the check in the Makefile with that version. Further discussion of the removal of if_ppp(4) can be found here: http://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html A better solution would be to port xfce4-netload-plugin to use ppp(8) instead of if_ppp(4), if possible. >How-To-Repeat: >Fix: See attached patch Patch attached with submission follows: Index: sysutils/xfce4-netload-plugin/Makefile =================================================================== RCS file: /home/pcvs/ports/sysutils/xfce4-netload-plugin/Makefile,v retrieving revision 1.30 diff -u -r1.30 Makefile --- sysutils/xfce4-netload-plugin/Makefile 10 Jan 2010 09:56:21 -0000 1.30 +++ sysutils/xfce4-netload-plugin/Makefile 18 Jan 2010 16:22:31 -0000 @@ -24,7 +24,7 @@ .include <bsd.port.pre.mk> -.if ${OSVERSION} >= 800000 +.if ${OSVERSION} >= 800045 BROKEN= does not compile: error: net/if_ppp.h: No such file or directory .endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201001181629.o0IGTZol076374>