Date: Wed, 3 Nov 1999 01:40:02 -0800 (PST) From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de> To: freebsd-bugs@FreeBSD.org Subject: Re: gnu/14664: tar checks for volno-file even if it shouldn't Message-ID: <199911030940.BAA69451@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR gnu/14664; it has been noted by GNATS.
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>,
FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: gnu/14664: tar checks for volno-file even if it shouldn't
Date: Wed, 3 Nov 1999 10:30:52 +0100
On Wed, 03-Nov-1999 at 10:31:35 +0200, Sheldon Hearn wrote:
>
>
> On Tue, 02 Nov 1999 19:49:53 +0100, Andre Albsmeier wrote:
>
> > - closeout_volume_number ();
> > + if (f_volno_file)
> > + closeout_volume_number ();
>
> If you got this change from the GNU tar maintainers, then we should
> probably commit it. If it's something you came up with yourself, you
I came up with it myself.
> should report it to the GNU tar maintainers and let me know; I'll
> suspend your PR and wait for you to open a new one when you have
> something "official" from the GNU tar maintainers.
I decided to look in tar-1.12.tar.gz from a gnu site before sending
mail to bug-gnu-utils and, look, here the fix can be found already:
buffer.c, around line 1555:
------------------------- snip ------------------------------
if (info_script_option)
{
if (volno_file_option)
closeout_volume_number ();
system (info_script_option);
}
------------------------- snap ------------------------------
The corresponding ChangeLog:
------------------------- snip ------------------------------
1996-04-23 Fran\xe7ois Pinard <pinard@iro.umontreal.ca>
...
* buffer.c (new_volume): Avoid calling closeout_volume_number if
the --volno-file option was not specified, so avoiding crashes.
------------------------- snap ------------------------------
I think it would be the best to update the whole tar (since there are
lots more bug fixes) but until this had been done, you could commit my fix.
Thanks,
-Andre
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199911030940.BAA69451>