Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 16 Jun 2018 18:29:24 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r335261 - head/tests/sys/audit
Message-ID:  <201806161829.w5GITOT3016963@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: asomers
Date: Sat Jun 16 18:29:24 2018
New Revision: 335261
URL: https://svnweb.freebsd.org/changeset/base/335261

Log:
  audit(4): add tests for pathconf(2) and friends
  
  pathconf, lpathconf, and fpathconf are included
  
  Submitted by:	aniketp
  MFC after:	2 weeks
  Sponsored by:	Google, Inc. (GSoC 2018)
  Differential Revision:	https://reviews.freebsd.org/D15842

Modified:
  head/tests/sys/audit/file-attribute-access.c

Modified: head/tests/sys/audit/file-attribute-access.c
==============================================================================
--- head/tests/sys/audit/file-attribute-access.c	Sat Jun 16 18:22:35 2018	(r335260)
+++ head/tests/sys/audit/file-attribute-access.c	Sat Jun 16 18:29:24 2018	(r335261)
@@ -661,6 +661,144 @@ ATF_TC_CLEANUP(faccessat_failure, tc)
 }
 
 
+ATF_TC_WITH_CLEANUP(pathconf_success);
+ATF_TC_HEAD(pathconf_success, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+					"pathconf(2) call");
+}
+
+ATF_TC_BODY(pathconf_success, tc)
+{
+	/* File needs to exist to call pathconf(2) */
+	ATF_REQUIRE((filedesc = open(path, O_CREAT, mode)) != -1);
+	FILE *pipefd = setup(fds, auclass);
+	/* Get the maximum number of bytes of filename */
+	ATF_REQUIRE(pathconf(path, _PC_NAME_MAX) != -1);
+	check_audit(fds, successreg, pipefd);
+	close(filedesc);
+}
+
+ATF_TC_CLEANUP(pathconf_success, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(pathconf_failure);
+ATF_TC_HEAD(pathconf_failure, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+					"pathconf(2) call");
+}
+
+ATF_TC_BODY(pathconf_failure, tc)
+{
+	FILE *pipefd = setup(fds, auclass);
+	/* Failure reason: file does not exist */
+	ATF_REQUIRE_EQ(-1, pathconf(errpath, _PC_NAME_MAX));
+	check_audit(fds, failurereg, pipefd);
+}
+
+ATF_TC_CLEANUP(pathconf_failure, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(lpathconf_success);
+ATF_TC_HEAD(lpathconf_success, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+					"lpathconf(2) call");
+}
+
+ATF_TC_BODY(lpathconf_success, tc)
+{
+	/* Symbolic link needs to exist to call lpathconf(2) */
+	ATF_REQUIRE_EQ(0, symlink("symlink", path));
+	FILE *pipefd = setup(fds, auclass);
+	/* Get the maximum number of bytes of symlink's name */
+	ATF_REQUIRE(lpathconf(path, _PC_SYMLINK_MAX) != -1);
+	check_audit(fds, successreg, pipefd);
+}
+
+ATF_TC_CLEANUP(lpathconf_success, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(lpathconf_failure);
+ATF_TC_HEAD(lpathconf_failure, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+					"lpathconf(2) call");
+}
+
+ATF_TC_BODY(lpathconf_failure, tc)
+{
+	FILE *pipefd = setup(fds, auclass);
+	/* Failure reason: symbolic link does not exist */
+	ATF_REQUIRE_EQ(-1, lpathconf(errpath, _PC_SYMLINK_MAX));
+	check_audit(fds, failurereg, pipefd);
+}
+
+ATF_TC_CLEANUP(lpathconf_failure, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(fpathconf_success);
+ATF_TC_HEAD(fpathconf_success, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of a successful "
+					"fpathconf(2) call");
+}
+
+ATF_TC_BODY(fpathconf_success, tc)
+{
+	pid = getpid();
+	snprintf(extregex, sizeof(extregex), "fpathconf.*%d.*success", pid);
+
+	/* File needs to exist to call fpathconf(2) */
+	ATF_REQUIRE((filedesc = open(path, O_CREAT, mode)) != -1);
+	FILE *pipefd = setup(fds, auclass);
+	/* Get the maximum number of bytes of filename */
+	ATF_REQUIRE(fpathconf(filedesc, _PC_NAME_MAX) != -1);
+	check_audit(fds, extregex, pipefd);
+	close(filedesc);
+}
+
+ATF_TC_CLEANUP(fpathconf_success, tc)
+{
+	cleanup();
+}
+
+
+ATF_TC_WITH_CLEANUP(fpathconf_failure);
+ATF_TC_HEAD(fpathconf_failure, tc)
+{
+	atf_tc_set_md_var(tc, "descr", "Tests the audit of an unsuccessful "
+					"fpathconf(2) call");
+}
+
+ATF_TC_BODY(fpathconf_failure, tc)
+{
+	FILE *pipefd = setup(fds, auclass);
+	const char *regex = "fpathconf.*return,failure : Bad file descriptor";
+	/* Failure reason: Bad file descriptor */
+	ATF_REQUIRE_EQ(-1, fpathconf(-1, _PC_NAME_MAX));
+	check_audit(fds, regex, pipefd);
+}
+
+ATF_TC_CLEANUP(fpathconf_failure, tc)
+{
+	cleanup();
+}
+
+
 ATF_TP_ADD_TCS(tp)
 {
 	ATF_TP_ADD_TC(tp, stat_success);
@@ -693,6 +831,13 @@ ATF_TP_ADD_TCS(tp)
 	ATF_TP_ADD_TC(tp, eaccess_failure);
 	ATF_TP_ADD_TC(tp, faccessat_success);
 	ATF_TP_ADD_TC(tp, faccessat_failure);
+
+	ATF_TP_ADD_TC(tp, pathconf_success);
+	ATF_TP_ADD_TC(tp, pathconf_failure);
+	ATF_TP_ADD_TC(tp, lpathconf_success);
+	ATF_TP_ADD_TC(tp, lpathconf_failure);
+	ATF_TP_ADD_TC(tp, fpathconf_success);
+	ATF_TP_ADD_TC(tp, fpathconf_failure);
 
 	return (atf_no_error());
 }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806161829.w5GITOT3016963>