Date: Wed, 5 May 2010 03:25:39 -0700 From: Rob Farmer <rfarmer@predatorlabs.net> To: David DEMELIER <demelier.david@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: unzip in basesystem. Message-ID: <l2rb025ceb71005050325n3fe54a57u66423817935638e1@mail.gmail.com> In-Reply-To: <t2pb3954bba1005050230kbdca43b2uc10d77d0adea41e6@mail.gmail.com> References: <u2hb3954bba1005050221vbca997cdka377a23f026e9d3d@mail.gmail.com> <t2pb3954bba1005050230kbdca43b2uc10d77d0adea41e6@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 5, 2010 at 2:30 AM, David DEMELIER <demelier.david@gmail.com> w=
rote:
> 2010/5/5 David DEMELIER <demelier.david@gmail.com>:
>> Hi,
>>
>> I noticed that unzip came into basesystem in src/usr.bin/unzip/. To
>> prevent port installing the ports/archivers/unzip one, I propose to
>> add this in bsd.port.mk
Unfortunately there are some problems with the base system unzip that
make it preferable to use the port. From the commit log for
bsd.port.mk:
9-CURRENT introduced unzip command to the base system. Unfortunately it =
is
not fully compatible with the archivers/unzip implementation and non-triv=
ial
amount of ports fail to build when using it. Thus we will keep using
archivers/unzip for unzipping source in Ports Collection until someone
volunteer to fix all individual ports. Two most common problems with bas=
e
unzip are:
* extracting files without +x flag (some ports rely to execute unzipped
configure scripts, for example)
* different semantics of CR/LF conversion
Error logs of failed port builds with in-base unzip can be made available=
on
request to portmgr@.
With hat: portmgr
--=20
Rob Farmer
>>
>> .if defined(USE_ZIP) && !exists(/usr/bin/unzip)
>> EXTRACT_DEPENDS+=3D =A0 =A0 =A0 ${LOCALBASE}/bin/unzip:${PORTSDIR}/archi=
vers/unzip
>> .endif
>>
>> Is that right ?
>>
>
> Sorry I gone too fast, I would add this in bsd.commands.mk too :
>
> .if exists(/usr/bin/unzip)
> UNZIP_CMD=3D/usr/bin/unzip
> .else
> UNZIP_CMD?=3D =A0 =A0 ${LOCALBASE}/bin/unzip
> .endif
>
> --
> Demelier David
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org=
"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?l2rb025ceb71005050325n3fe54a57u66423817935638e1>