Date: Sun, 29 Dec 2013 15:51:19 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Dimitry Andric <dim@FreeBSD.org>, Adrian Chadd <adrian@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r259896 - head/sys/dev/cxgb/common Message-ID: <52C08B47.70106@FreeBSD.org> In-Reply-To: <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org> References: <201312252245.rBPMjX5J046556@svn.freebsd.org> <CAJ-Vmo=FufoALvqW-y9iXk%2BfHXDzNcd1riXX5%2Bg_1kG-Kus1=w@mail.gmail.com> <76C5CECF-1A27-4245-B5D1-335C46B253E7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26.12.2013 06:13, Dimitry Andric wrote: > On 26 Dec 2013, at 02:51, Adrian Chadd <adrian@freebsd.org> wrote: >> I'd prefer you didn't remove unused code in drivers like this. If you >> must, #if 0 them out. > I don't mind either way, but some other people are very much opposed to > littering code with #if 0'd sections. So, how do to determine what is > right in each situation? :-) > FWIW, I am also in favor of removing instead of #if 0. If we really need the code back, we have subversion for that. I guess an exception would be on contributed code, where one still wants to keep things similar. Just my 0.02$, no strong feelings about either way. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52C08B47.70106>