Date: Mon, 21 Oct 2024 18:21:40 +0000 (UTC) From: Maxim Konovalov <maxim@freebsd.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b88df1e893c4 - main - Reapply "sbin/ping: allow normal users to specify larger packets" Message-ID: <1e630992-e41c-2edd-ef48-61396146f72c@maxim.int.ru> In-Reply-To: <1791968192.4471640.1729534703845@mail.yahoo.com> References: <202410161840.49GIe8CR000407@gitrepo.freebsd.org> <f0575f7e-e155-85a7-fa7c-5a67af27ef63@maxim.int.ru> <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru> <1791968192.4471640.1729534703845@mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Pedro, No worries at all! Maxim On Mon, 21 Oct 2024, 18:18-0000, Pedro Giffuni wrote: > Sorry ... > I completely missed this was causing any trouble. My filters threw the reply into a folder that I don't look at regularly. > Thanks to markj@ for backing it out. > Pedro. > On Friday, October 18, 2024 at 02:41:12 PM GMT-5, maxim@freebsd.org <maxim@freebsd.org> wrote: > > Hi Pedro, > > Unless you have a plan to address this issue please backout this code > as it is clearly wrong. > > Thanks, > > Maxim > > On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote: > > > Hi Pedro, > > > > No, this is not right. Let me clarify: > > > > (1) I never told that there are any issues with the tests. I just > > mumbled that the tests should catch such regression though I never > > checked if they actually did. > > > > (2) The MAXPAYLOAD calculation in the code below is not fully correct. > > > > It should be > > > > 65535 - 20 (ip header) - 8 (icmp part) = 65507 without IP options > > > > OR > > > > 65535 - 20 (ip header) - 40 (ip options) - 8 (icmp part) = 65467 with > > IP options, ie. whenever you run ping -R. > > > > The code below hardcoded the latter value which is simply wrong. > > > > I wouldn't rely on the fact that you get it from other BSD flavours > > and would recommend to have this code reviewed before committing it. > > > > Maxim > > > > -- Maxim Konovalov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1e630992-e41c-2edd-ef48-61396146f72c>