Date: Fri, 17 Aug 2018 16:31:42 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 Message-ID: <ef873364-625a-ca2d-6d2b-8b1d567df8c6@yandex.ru> In-Reply-To: <CAOtMX2gzWCGBL80N7e1J1pLeBnPv6t18Bkw9vmobJv%2BkDwqcCw@mail.gmail.com> References: <201808140754.w7E7sEFs018313@repo.freebsd.org> <CAOtMX2gzWCGBL80N7e1J1pLeBnPv6t18Bkw9vmobJv%2BkDwqcCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a Content-Type: multipart/mixed; boundary="HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz"; protected-headers="v1" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Alan Somers <asomers@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <ef873364-625a-ca2d-6d2b-8b1d567df8c6@yandex.ru> Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 References: <201808140754.w7E7sEFs018313@repo.freebsd.org> <CAOtMX2gzWCGBL80N7e1J1pLeBnPv6t18Bkw9vmobJv+kDwqcCw@mail.gmail.com> In-Reply-To: <CAOtMX2gzWCGBL80N7e1J1pLeBnPv6t18Bkw9vmobJv+kDwqcCw@mail.gmail.com> --HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz Content-Type: multipart/mixed; boundary="------------39C66C75E0503693ED0220C5" Content-Language: en-US This is a multi-part message in MIME format. --------------39C66C75E0503693ED0220C5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 16.08.2018 21:34, Alan Somers wrote: > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov <ae@freebsd.org > <mailto:ae@freebsd.org>> wrote: >=20 > Author: ae > Date: Tue Aug 14 07:54:14 2018 > New Revision: 337736 > URL: https://svnweb.freebsd.org/changeset/base/337736 > <https://svnweb.freebsd.org/changeset/base/337736>; >=20 > Log: > =C2=A0 Restore ability to send ICMP and ICMPv6 redirects. >=20 > =C2=A0 It was lost when tryforward appeared. Now ip[6]_tryforward w= ill be > enabled > =C2=A0 only when sending redirects for corresponding IP version is > disabled via > =C2=A0 sysctl. Otherwise will be used default forwarding function. >=20 > =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0221137 >=20 > This change broke the sys/netipsec/tunnel tests.=C2=A0 I don't know if = it's a > limitation of the tests, or a genuine kernel bug, but I bisected the > regression down to this change.=C2=A0 Can you please fix it? >=20 > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/testReport/sys.= netipsec.tunnel/empty/v4/ I think it is because IPv4 tests use broadcast addresses in some places. The attached patch fixes the test for me. --=20 WBR, Andrey V. Elsukov --------------39C66C75E0503693ED0220C5 Content-Type: text/x-patch; name="ipsec.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ipsec.diff" Index: tests/sys/netipsec/tunnel/utils.subr =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- tests/sys/netipsec/tunnel/utils.subr (revision 337961) +++ tests/sys/netipsec/tunnel/utils.subr (working copy) @@ -57,8 +57,8 @@ ist_v4_setup () jexec ipsecA ifconfig ${epair_LAN_A}b 192.0.2.2/30 up jexec ipsecA ifconfig ${epair_PUB_A}a 198.51.100.2/30 up jexec router ifconfig ${epair_PUB_A}b 198.51.100.1/30 up - jexec router ifconfig ${epair_PUB_B}b 198.51.100.6/30 up - jexec ipsecB ifconfig ${epair_PUB_B}a 198.51.100.7/30 up + jexec router ifconfig ${epair_PUB_B}b 198.51.100.5/30 up + jexec ipsecB ifconfig ${epair_PUB_B}a 198.51.100.6/30 up jexec ipsecB ifconfig ${epair_LAN_B}b 203.0.113.2/30 up jexec hostB ifconfig ${epair_LAN_B}a 203.0.113.1/30 up jexec ipsecA sysctl net.inet.ip.forwarding=3D1 @@ -66,7 +66,7 @@ ist_v4_setup () jexec ipsecB sysctl net.inet.ip.forwarding=3D1 jexec hostA route add default 192.0.2.2 jexec ipsecA route add default 198.51.100.1 - jexec ipsecB route add default 198.51.100.6 + jexec ipsecB route add default 198.51.100.5 jexec hostB route add default 203.0.113.2 } =20 @@ -109,7 +109,7 @@ ist_setkey() SRC_LAN=3D"192.0.2.0/24" DST_LAN=3D"203.0.113.0/24" SRC_GW=3D"198.51.100.2" - DST_GW=3D"198.51.100.7" + DST_GW=3D"198.51.100.6" else SRC_LAN=3D"2001:db8:1::/64" DST_LAN=3D"2001:db8:45::/64" --------------39C66C75E0503693ED0220C5-- --HvPTNh4d52KObrDfnjB1dOnRmmXZU4SJz-- --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlt2zj4ACgkQAcXqBBDI oXpXKgf/c1DcFBelAdXHV780rjVq7+8u9umfEehVd4ulPRfASj4y+A+EQF3aeShT JrQg8D6yrGVBJE7A5iX7QWHb8N26n2MCZTYgmMw5hSni20yAE1F01I21RTWKuOHz AZ5k+ZD17VVj5021kgZC/CdBomXYAtdr64sfQJWsnsqB7mY1s/I9vgTuWrCOGAi5 Y6pmonfitSQOEKtXfDaw5A3KKlY3Y71guI5JhsKn8hAwcY5kCY8blcQE8naIj93h Nv6UBpRRRC+F8fuYffyGk01WXdpaSqOZmTcbYqFhb8E3icejBxXRX1X0UIfLuDrf Mur/6RcELUxfbuHpaUkvKIf+guTIiQ== =pFQf -----END PGP SIGNATURE----- --mWWUn5o6axP8hW17d53NkBOxTUpMH7w5a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ef873364-625a-ca2d-6d2b-8b1d567df8c6>