Date: Fri, 28 Feb 2014 23:50:01 GMT From: Matthew Ahrens <mahrens@delphix.com> To: freebsd-fs@FreeBSD.org Subject: Re: kern/185858: [zfs] zvol clone can't see new device Message-ID: <201402282350.s1SNo192036871@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/185858; it has been noted by GNATS. From: Matthew Ahrens <mahrens@delphix.com> To: bug-followup@freebsd.org Cc: Subject: Re: kern/185858: [zfs] zvol clone can't see new device Date: Fri, 28 Feb 2014 15:41:07 -0800 --bcaec520f69bc84d2a04f37ff83d Content-Type: text/plain; charset=ISO-8859-1 I looked for differences between the illumos and FreeBSD code and found that zfs_ioc_create() has this: 3310#ifdef __FreeBSD__ 3311 if (error == 0 && type == DMU_OST_ZVOL) 3312 zvol_create_minors(fsname); 3313#endif It seems like similar code would be needed in zfs_ioc_clone(), but isn't there. The "type" (ZVOL vs ZPL filesystem) isn't as immediately available in zfs_ioc_clone(), so it might be a little tricker to add the code to zfs_ioc_clone(). --matt --bcaec520f69bc84d2a04f37ff83d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>I looked for differences between the illumos and Free= BSD code and found that zfs_ioc_create() has this:</div><div><br></div><div= >3310#ifdef __FreeBSD__</div><div>3311<span class=3D"" style=3D"white-space= :pre"> </span>if (error =3D=3D 0 && type =3D=3D DMU_OST_ZVOL)</div> <div>3312<span class=3D"" style=3D"white-space:pre"> </span>zvol_create_mi= nors(fsname);</div><div>3313#endif</div><div><br></div><div>It seems like s= imilar code would be needed in zfs_ioc_clone(), but isn't there. =A0The= "type" (ZVOL vs ZPL filesystem) isn't as immediately availab= le in zfs_ioc_clone(), so it might be a little tricker to add the code to z= fs_ioc_clone().</div> <div><br></div><div>--matt</div></div> --bcaec520f69bc84d2a04f37ff83d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402282350.s1SNo192036871>