Date: Thu, 24 Sep 2009 07:11:23 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/amd64/pci pci_cfgreg.c src/sys/dev/pci pcireg.h src/sys/i386/pci pci_cfgreg.c Message-ID: <200909240712.n8O7CFl6077450@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
avg 2009-09-24 07:11:23 UTC
FreeBSD src repository
Modified files:
sys/amd64/pci pci_cfgreg.c
sys/dev/pci pcireg.h
sys/i386/pci pci_cfgreg.c
Log:
SVN rev 197450 on 2009-09-24 07:11:23Z by avg
number of cleanups in i386 and amd64 pci md code
o introduce PCIE_REGMAX and use it instead of ad-hoc constant
o where 'reg' parameter/variable is not already unsigned, cast it to
unsigned before comparison with maximum value to cut off negative
values
o use PCI_SLOTMAX in several places where 31 or 32 were explicitly used
o drop redundant check of 'bytes' in i386 pciereg_cfgread() - valid
values are already checked in the subsequent switch
Reviewed by: jhb
MFC after: 1 week
Revision Changes Path
1.116 +8 -8 src/sys/amd64/pci/pci_cfgreg.c
1.74 +1 -0 src/sys/dev/pci/pcireg.h
1.135 +7 -7 src/sys/i386/pci/pci_cfgreg.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909240712.n8O7CFl6077450>