Date: Sat, 13 Apr 1996 20:31:38 +0200 (MET DST) From: J Wunsch <j@uriah.heep.sax.de> To: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org Subject: Re: cvs commit: src/sbin/nfsd nfsd.c Message-ID: <199604131831.UAA21438@uriah.heep.sax.de> In-Reply-To: <199604131814.EAA14571@godzilla.zeta.org.au> from "Bruce Evans" at Apr 14, 96 04:14:11 am
next in thread | previous in thread | raw e-mail | index | archive | help
As Bruce Evans wrote:
>
> >> Unless otherwise specified, four servers for UDP transport are started.
>
> I think this says that 4 servers for UDP transport are started _if UDP
> service is enabled_.
Ah, what sense does it make to start a daemon just with the intention
to do nothing? (No args -> do nothing.)
Of course, the English language is perhaps more ambigous than C. :-)
> Now UDP is always enabled unless nfsd is execed in an unusual way to
> get argc == 0.
>
> Bruce
>
> *** nfsd.c~ Sat Apr 13 20:31:54 1996
> --- nfsd.c Sat Apr 13 20:37:20 1996
> ***************
> *** 195,198 ****
> --- 195,200 ----
> #define USAGE "[-rtu] [-n num_servers]"
> #endif
> + if (argc <= 1)
> + udpflag = 1;
> while ((ch = getopt(argc, argv, GETOPT)) != EOF)
> switch (ch) {
> ***************
> *** 230,234 ****
> usage();
> };
> - if(argc) udpflag = 1;
> argv += optind;
> argc -= optind;
> --- 232,235 ----
>
Ain't this reverse? (But i agree that it needs to be fixed.)
--
cheers, J"org
joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604131831.UAA21438>