Date: Mon, 10 Jul 2023 12:26:01 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 29cbe944e928 - main - CONTRIBUTING.md: minor changes Message-ID: <CANCZdfo4eaaK8oqy5Qb0Ohz-J3Crhd2F9meGALV=pT3qEyBcWw@mail.gmail.com> In-Reply-To: <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org> References: <202307072123.367LNZ4J060993@gitrepo.freebsd.org> <ZKj_DU6rzJunuHLb@FreeBSD.org> <CANCZdfq9o8qA%2B=CxOW1y5LybDqW0XvdNiFhcY_CjDEvVZf9g_w@mail.gmail.com> <1e07dc3f-071c-bd8d-3f15-4aaee60582f6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jul 10, 2023 at 10:00 AM John Baldwin <jhb@freebsd.org> wrote: > On 7/9/23 8:06 PM, Warner Losh wrote: > > On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <danfe@freebsd.org> > wrote: > > > >> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote: > >>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa > >>> > >>> CONTRIBUTING.md: minor changes > >>> > >>> - Misspelled GitHub > >>> - angle bracket not escaped correctly > >>> - Double white spaces > >> > >> You've removed them, while they are typically used after full stops > >> as texts render better with them unless you're using proportional > >> font. > >> > > > > It's the modern way.... but WuerfelDev also had a commit that backed > > that part out that I didn't fold in... > > I'm still torn since I see so many conflicting things about it :( > > > > I'm leaning towards putting them back. > > FWIW, I still use monospace fonts for code and thus still use double spaces > for the reason Alexey stated. Reading code in proportional fonts (where > spacing is naturally wider at sentence breaks) is not really viable with > style(9) which mixes tabs with spaces for indentation. > OK. I've just pushed the other half of 788 where the submitter backed out the removal of the double spaces. And now I know why they should remain. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 10, 2023 at 10:00 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 7/9/23 8:06 PM, Warner Losh wrote:<br> > On Sat, Jul 8, 2023 at 12:15 AM Alexey Dokuchaev <<a href="mailto:danfe@freebsd.org" target="_blank">danfe@freebsd.org</a>> wrote:<br> > <br> >> On Fri, Jul 07, 2023 at 09:23:35PM +0000, Warner Losh wrote:<br> >>> commit 29cbe944e9287c2e61928c456512d3990aaffdaa<br> >>><br> >>> CONTRIBUTING.md: minor changes<br> >>><br> >>> - Misspelled GitHub<br> >>> - angle bracket not escaped correctly<br> >>> - Double white spaces<br> >><br> >> You've removed them, while they are typically used after full stops<br> >> as texts render better with them unless you're using proportional<br> >> font.<br> >><br> > <br> > It's the modern way.... but WuerfelDev also had a commit that backed<br> > that part out that I didn't fold in...<br> > I'm still torn since I see so many conflicting things about it :(<br> > <br> > I'm leaning towards putting them back.<br> <br> FWIW, I still use monospace fonts for code and thus still use double spaces<br> for the reason Alexey stated. Reading code in proportional fonts (where<br> spacing is naturally wider at sentence breaks) is not really viable with<br> style(9) which mixes tabs with spaces for indentation.<br></blockquote><div><br></div><div>OK. I've just pushed the other half of 788 where the submitter backed out the removal</div><div>of the double spaces. And now I know why they should remain.</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo4eaaK8oqy5Qb0Ohz-J3Crhd2F9meGALV=pT3qEyBcWw>