Date: Sun, 21 Sep 1997 18:28:09 -0500 (EST) From: "John S. Dyson" <toor@dyson.iquest.net> To: nate@mt.sri.com (Nate Williams) Cc: dyson@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net ppp_deflate.c Message-ID: <199709212328.SAA03748@dyson.iquest.net> In-Reply-To: <199709212257.QAA28083@rocky.mt.sri.com> from Nate Williams at "Sep 21, 97 04:57:34 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Williams said: > John Dyson writes: > > dyson 1997/09/21 15:31:22 PDT > > > > Modified files: > > sys/net ppp_deflate.c > > Log: > > Remove an unfortunate name clash with the zalloc/zfree routines. Since the > > ppp_deflate code uses the names locally - it looses. > > Since the ppp code is 'externally' maintained code, did you submit this > patch to the author? If not, then we have to keep maintaining this > change everytime we update it, which would imply that it would be easier > to change the 'locally' maintained code. > > (Also, changing legacy code that uses names recently introduced seems > silly, since the old names already existed.) > I disagree, when it was taking up global namespace unnecessarily. I knew that there might be a bit of a controversy, but zalloc for the zone allocator seems to be make sense more, globally, than using it as zlib_alloc (which it should have been named originally, making more sense.) Sorry, but I disagree here. -- John dyson@freebsd.org jdyson@nc.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709212328.SAA03748>