Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Feb 2014 22:38:25 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r262310 - head/share/mk
Message-ID:  <201402212238.s1LMcPnY097559@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: dim
Date: Fri Feb 21 22:38:25 2014
New Revision: 262310
URL: http://svnweb.freebsd.org/changeset/base/262310

Log:
  Move the part in bsd.own.mk that sets -Wno-c++11-extensions for clang to
  bsd.sys.mk, where it really belongs.  This also causes the flag to get
  added when clang is *not* the default system compiler, but is still
  used, e.g. by setting WITH_CLANG_IS_CC manually.
  
  MFC after:	3 days

Modified:
  head/share/mk/bsd.own.mk
  head/share/mk/bsd.sys.mk

Modified: head/share/mk/bsd.own.mk
==============================================================================
--- head/share/mk/bsd.own.mk	Fri Feb 21 22:29:09 2014	(r262309)
+++ head/share/mk/bsd.own.mk	Fri Feb 21 22:38:25 2014	(r262310)
@@ -420,15 +420,6 @@ __DEFAULT_YES_OPTIONS+=GCC
 .else
 __DEFAULT_NO_OPTIONS+=GCC GNUCXX
 .endif
-# The libc++ headers use c++11 extensions.  These are normally silenced because
-# they are treated as system headers, but we explicitly disable that warning
-# suppression when building the base system to catch bugs in our headers.
-# Eventually we'll want to start building the base system C++ code as C++11,
-# but not yet.
-_COMPVERSION!= ${CC} --version
-.if ${_COMPVERSION:Mclang}
-CXXFLAGS+=	-Wno-c++11-extensions
-.endif
 .else
 # If clang is not cc, then build gcc by default
 __DEFAULT_NO_OPTIONS+=CLANG_IS_CC

Modified: head/share/mk/bsd.sys.mk
==============================================================================
--- head/share/mk/bsd.sys.mk	Fri Feb 21 22:29:09 2014	(r262309)
+++ head/share/mk/bsd.sys.mk	Fri Feb 21 22:38:25 2014	(r262310)
@@ -120,6 +120,12 @@ CLANG_NO_IAS=	 -no-integrated-as
 CLANG_OPT_SMALL= -mstack-alignment=8 -mllvm -inline-threshold=3\
 		 -mllvm -enable-load-pre=false -mllvm -simplifycfg-dup-ret
 CFLAGS+=	 -Qunused-arguments
+# The libc++ headers use c++11 extensions.  These are normally silenced because
+# they are treated as system headers, but we explicitly disable that warning
+# suppression when building the base system to catch bugs in our headers.
+# Eventually we'll want to start building the base system C++ code as C++11,
+# but not yet.
+CXXFLAGS+=	 -Wno-c++11-extensions
 CFLAGS+=	 ${CFLAGS.clang}
 CXXFLAGS+=	 ${CXXFLAGS.clang}
 .else # !CLANG



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402212238.s1LMcPnY097559>