Date: Sun, 25 Mar 2018 22:27:08 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: [Bug 226926] [PATCH] Tools/scripts/bump-revision.sh lacks a safety belt Message-ID: <bug-226926-12827-qCjW36KrID@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-226926-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-226926-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226926 Matthias Andree <mandree@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mandree@FreeBSD.org --- Comment #1 from Matthias Andree <mandree@FreeBSD.org> --- Since Gerald pointed me to the PR, I take the liberty to add some unsolicit= ed feedback, I hope he does not mind. - personally, I prefer var=3D"$(some command)" over the backtick notation, because it resolves doubts about quoting - I suggest to use "pkg version -t pre post" as a comparison, rather than [= ... -le ... ] (aka. test ... -le ...) because I *believe* (without testing) that the existing version would not support lexicographical wraps when numbers g= et longer, for instance, when bumping from PORTREVISION=3D9 to ...=3D10 becaus= e 10 sorts before 9 if you sort them as string. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-226926-12827-qCjW36KrID>