Date: Fri, 16 Aug 2002 16:40:50 -0700 From: Peter Wemm <peter@wemm.org> To: Maxim Sobolev <max@vega.com> Cc: ikostov@otel.net (Iasen Kostov), julian@elischer.org (Julian Elischer), sobomax@FreeBSD.ORG (Maxim Sobolev), hackers@FreeBSD.ORG, net@FreeBSD.ORG Subject: Re: Increasing size of if_flags field in the ifnet structure [patch Message-ID: <20020816234050.6B56E2A7D6@canning.wemm.org> In-Reply-To: <200208161222.g7GCM8Rt005388@vega.vega.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Maxim Sobolev wrote: > > > There is no much point in this patch, because it will increase size of > > > struct ifreq, which means that no ioctl's from older apps will be accept ed > > > anyway. Therefore, there is no difference between those two, while my > > > approach is obviously cleaner. > > > > It does not increase size of struct ifreq. > > This is a union not a struct as You see. > > Oh, yes, you are obviously correct. However, I still wonder if your patch > is endianless-safe. FWIW, for 4.x, endianness is not a problem since all the 4.x platforms are little-endian. For 5.x we should make a clean break. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020816234050.6B56E2A7D6>