Date: Mon, 17 Nov 2014 12:31:14 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: freebsd-security@freebsd.org, current@freebsd.org Subject: Re: CFR: AES-GCM and OpenCrypto work review Message-ID: <20141117203114.GQ24601@funkthat.com> In-Reply-To: <546A3FB8.8080808@yandex.ru> References: <20141108042300.GA24601@funkthat.com> <54655257.8080705@yandex.ru> <54660389.9060409@yandex.ru> <20141114193911.GR24601@funkthat.com> <20141115024201.GW24601@funkthat.com> <546744B6.8040504@yandex.ru> <20141116061525.GG24601@funkthat.com> <546A3FB8.8080808@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey V. Elsukov wrote this message on Mon, Nov 17, 2014 at 21:34 +0300:
> On 16.11.2014 09:15, John-Mark Gurney wrote:
> > Ok, I was able to reproduce the bug, and found that my optimization
> > for single mbuf packets was broken... I've attached a new patch
> > that has the fix...
> >
> > This patch also has added a lock around the aesni fpu context setting
> > to deal w/ the issue that I had...
> >
> > Let me know how things are w/ this new patch.
>
> with this patch all works as expected.
Just so you know, even tunnel mode w/ aesni on a clean HEAD can panic..
I just got a:
panic: dummy ctx
from the tunnel mode by having two machines ping -f'ing each other...
This is a different form of the same panic I posted about earlier w/
the fpu context being reused for different threads...
I plan on committing the patch w/o the mtx_lock as including the lock
will significantly impact people who use geli...
I am working on a fix for this w/ kib that will allow us to not
allocate an fpu context and get things a little more stable, but there
are other bugs that also need to be addressed before aesni is safe
to use w/ IPsec...
Thanks for testing!
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141117203114.GQ24601>