Date: Thu, 03 Jun 1999 12:12:52 +0100 From: Roger Hardiman <roger@cs.strath.ac.uk> To: cvs-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org Cc: multimedia@FreeBSD.org, Greg Pavelcak <gpavelcak@philos.umass.edu> Subject: Bt848 driver broken in -current (was /dev/bktr0 failed) Message-ID: <37566334.7A75EDC4@cs.strath.ac.uk>
next in thread | raw e-mail | index | archive | help
Hi,
Poul's recent cdevsw changes to -current have broken the
bt848/bt878 bktr driver.
> phk 1999/05/30 09:53:50 PDT
> This commit should be a extensive NO-OP:
> Reformat and initialize correctly all "struct cdevsw".
Not quite a NO-OP, but the slip up was a subtle one and easy
to get wrong.
The new cdevsw code uses a new function call
which is added to the bktr_probe() function.
cdevsw_add(&bktr_cdevsw);
Unfortunatly it was added to the BSDI bktr_probe() code and
not the FreeBSD bktr_probe() code.
#ifdef __bsdi__
.. blah blah blah
.. bktr_probe() <- cdev change went here
.. blah blah blah
#endif
#ifdef __FreeBSD__
.. blah blah blah
.. bktr_probe() <- it should be here
.. blah blah blah
#endif
THE FIX...
Move the following 3 lines
static int once;
if (!once++)
cdevsw_add(&bktr_cdevsw);
from the _BSDI_ bktr_probe
to the _FreeBSD_ bktr_probe
and it should all work.
I'll try and do a commit this evening, when I can test it.
It is temping to rip out the BSDI code.
Althouth the NetBSD/OpenBSD people want me to add their patches to the
source.
Bye
Roger
--
Roger Hardiman
Strathclyde Uni Telepresence Research Group, Glasgow, Scotland.
http://telepresence.dmem.strath.ac.uk 0141 548 2897
roger@cs.strath.ac.uk
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37566334.7A75EDC4>