Date: Sun, 19 Sep 1999 14:59:52 -0500 (CDT) From: Jason Young <doogie@anet-stl.com> To: Warner Losh <imp@village.org> Cc: "David E. O'Brien" <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa if_ep.c Message-ID: <Pine.BSF.3.96.990919145518.26021C-100000@earth.anet-stl.com> In-Reply-To: <199909191931.NAA11720@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Argh, I just spotted an error in my code. In ep_pccard_init,
epb->cmd_off = 0;
epb->prod_id = get_e(sc, EEPROM_PROD_ID);
if (bootverbose) printf("ep%d: Pass 1 of 2 detection failed
(nonfatal)\n", is->id_unit);
if (!ep_pccard_identify(epb, is->id_unit)) {
epb->cmd_off = 2;
epb->prod_id = get_e(sc, EEPROM_PROD_ID);
if (!ep_pccard_identify(epb, is->id_unit)) {
if (bootverbose) printf("ep%d: Pass 2 of 2 detection failed
(fatal!)\n", is->id_unit);
Lines 3 and 4 should be transposed. The code isn't functionally broken,
but it should only report a diagnostic failure if the failure has indeed
occurred.
I unfortunately don't have any other 3Com ISA or PCMCIA cards to test with
other than the one I added support for. I used to, but we had a major
lightning hit come in and blow up damn near every ethernet card in the
office. I had to replace all the cards with brand new Intel Etherexpress
Pro/100Bs. What a shame! :>
Jason Young
accessUS Chief Network Engineer
On Sun, 19 Sep 1999, Warner Losh wrote:
> In message <Pine.BSF.3.96.990919123906.25779A-100000@earth.anet-stl.com> Jason Young writes:
> : Thanks! Please be on the lookout for compatibility breakage though, the
> : new probe logic -is- a little bit questionable in my mind although it
> : seems to work.
>
> The acid test will come later today when I update my laptop to a new
> kernel and see if the fix breaks my 3C589D :-)
>
> Warner
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990919145518.26021C-100000>