Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Oct 2017 03:54:51 +0000
From:      Li-Wen Hsu <lwhsu@FreeBSD.org>
To:        Andrew Turner <andrew@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r324177 - in head/sys: amd64/amd64 amd64/include conf dev/efidev modules/efirt sys
Message-ID:  <20171002035451.GA73956@freefall.freebsd.org>
In-Reply-To: <201710011952.v91JqmUS016132@repo.freebsd.org>
References:  <201710011952.v91JqmUS016132@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 01, 2017 at 19:52:48 +0000, Andrew Turner wrote:
> Author: andrew
> Date: Sun Oct  1 19:52:47 2017
> New Revision: 324177
> URL: https://svnweb.freebsd.org/changeset/base/324177
> 
> Log:
>   To prepare for adding EFI runtime services support on arm64 move the
>   machine independent parts of the existing code to a new file that can be
>   shared between amd64 and arm64.
>   
>   Reviewed by:	kib (previous version), imp
>   Sponsored by:	DARPA, AFRL
>   Differential Revision:	https://reviews.freebsd.org/D12434
> 
> Added:
>   head/sys/amd64/amd64/efirt_machdep.c
>      - copied, changed from r324176, head/sys/amd64/amd64/efirt.c
>   head/sys/dev/efidev/efirt.c
>      - copied, changed from r324100, head/sys/amd64/amd64/efirt.c
> Deleted:
>   head/sys/amd64/amd64/efirt.c
> Modified:
>   head/sys/amd64/include/efi.h
>   head/sys/conf/files
>   head/sys/conf/files.amd64
>   head/sys/modules/efirt/Makefile
>   head/sys/sys/efi.h

[...]

> Modified: head/sys/amd64/include/efi.h
> ==============================================================================
> --- head/sys/amd64/include/efi.h	Sun Oct  1 19:40:29 2017	(r324176)
> +++ head/sys/amd64/include/efi.h	Sun Oct  1 19:52:47 2017	(r324177)
> @@ -32,6 +32,8 @@
>  #ifndef __AMD64_INCLUDE_EFI_H_
>  #define __AMD64_INCLUDE_EFI_H_
>  
> +#include <isa/rtc.h>
> +

Hi,

This seems breaking build, could you check this:

00:10:09.430 --- all_subdir_lib/libefivar ---
00:10:09.430 In file included from /usr/src/lib/libefivar/efivar.c:30:
00:10:09.430 In file included from /usr/src/lib/libefivar/efivar.h:33:
00:10:09.430 In file included from /usr/obj/usr/src/tmp/usr/include/sys/efi.h:33:
00:10:09.430 /usr/obj/usr/src/tmp/usr/include/machine/efi.h:35:10: fatal error: 'isa/rtc.h' file not found
00:10:09.430 #include <isa/rtc.h>
00:10:09.430          ^~~~~~~~~~~

Full log:
https://ci.freebsd.org/job/FreeBSD-head-amd64-build/5244/console

Thanks,
Li-Wen

-- 
Li-Wen Hsu <lwhsu@FreeBSD.org>
https://lwhsu.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171002035451.GA73956>