Date: Fri, 20 Mar 2020 10:35:48 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 204521] [new driver] [request] Port rtsx from OpenBSD to FreeBSD Message-ID: <bug-204521-227-8SIvOCDNPR@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204521-227@https.bugs.freebsd.org/bugzilla/> References: <bug-204521-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204521 --- Comment #42 from Gary Jennejohn <gljennjohn@gmail.com> --- (In reply to hlh from comment #38) The message from dirkx led me to look more closely at the OpenBSD code. OpenBSD never sets intr_status to 0 before calling rtsx_wait_intr(). That makes sense because, theoretically, the interrupt could be raised before rtsx_wait_intr() is entered. In that case, setting intr_status to 0 would overwrite its setting in the interrupt handler and result in a false timeout error. I tested NOT setting intr_status to 0 and the driver works just as well (or badly) as before. Actually, setting it to zero is not really necessary due to this code in rtsx_wait_intr(): sc->rtsx_intr_status &= ~status; So, I suggest, but do not demand, at least commenting out the lines where intr_status is set to 0. I leave it up to you. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204521-227-8SIvOCDNPR>