Date: Tue, 15 Aug 2000 10:17:36 +0100 From: Brian Somers <brian@Awfulhak.org> To: Archie Cobbs <archie@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: cvs commit: src/sys/netgraph ng_pppoe.c Message-ID: <200008150917.KAA01236@hak.lan.Awfulhak.org> In-Reply-To: Message from Archie Cobbs <archie@FreeBSD.ORG> of "Mon, 14 Aug 2000 18:25:04 PDT." <200008150125.SAA40367@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> archie 2000/08/14 18:25:04 PDT
>
> Modified files: (Branch: RELENG_4)
> sys/netgraph ng_pppoe.c
> Log:
> MFC: (rev. 1.26) strip address and control field bytes from outgoing frames
> MFC: (rev. 1.24) misc fixes (not described in that commit message)
>
> Revision Changes Path
> 1.23.2.1 +29 -5 src/sys/netgraph/ng_pppoe.c
I didn't see the original commit (sorry, I would have followed-up to
that).
Is this actually necessary ? Surely the ppp implementation shouldn't
be prepending this stuff ? I would think that if this functionality
is required it should be enabled/disabled via a control message and
should work on inbound data too.
--
Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org>
<http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org>
Don't _EVER_ lose your sense of humour !
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200008150917.KAA01236>