Date: Sun, 31 Jul 2005 20:59:25 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Alexander Leidinger <netchild@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 ObsoleteFiles.inc src/share/man/man7 build.7 Message-ID: <20050731185925.GU68965@obiwan.tataz.chchile.org> In-Reply-To: <20050731102343.35bc4aa9@Magellan.Leidinger.net> References: <200507292145.j6TLjkNc099549@repoman.freebsd.org> <86k6j8g7mq.fsf@xps.des.no> <20050730124053.507227dd@Magellan.Leidinger.net> <863bpvmnww.fsf@xps.des.no> <20050731102343.35bc4aa9@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Alexander,
> > BTW, I don't really see why {check,delete}-old-* should be restricted
> > to native environments. DESTDIR might point to e.g. an NFS-exported
> > filesystem from which thin clients of a different architecture boot.
>
> Because of ObsoleteFiles.inc:
> ---snip---
> .if ${MACHINE_ARCH} != "alpha" && ${MACHINE_ARCH} != "sparc64"
> # 20040130: libkse renamed to libpthread
> OLD_FILES+=usr/lib/libkse.a
> OLD_FILES+=usr/lib/libkse.so
> .endif
> ---snip---
>
> We could change this to TARGET_ARCH instead, but then the user has to
> set it, else he removes non-obsolete files. Even when we make it a
> documented requirement, I don't have a good feeling regarding this.
> There's too much foot-shooting potential if someone forgets to set it.
> I think it's more user friendly / ergonomic to keep the current
> restriction. With the restriction in place you need to have 2
> files (Makefile.inc1 and ObsoleteFiles.inc) or the NFS exported src
> directory on one client to remove the old files. This is a little bit
> more work, but forces the administrator to think a little bit about what
> he does. It's part of my "as failsafe as possible" design of this
> feature.
This sounds as a hack, but couldn't you use file(1) on ${DESTDIR}/bin/ls
to identify the architecture it's running ? It would at least avoid
breaking POLA.
Regards,
--
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050731185925.GU68965>