Date: Wed, 13 Jan 2021 12:22:51 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Filippo Moretti <filippomore@yahoo.com>, FreeBSD Current <current@freebsd.org> Subject: Re: Problem compiling drm-current-kmod Message-ID: <20210113122251.b6d35bca0f20ae276dc13018@bidouilliste.com> In-Reply-To: <20210113114531.77e8df2f65a61726c8935dcd@bidouilliste.com> References: <1798034025.1533341.1610533921529.ref@mail.yahoo.com> <1798034025.1533341.1610533921529@mail.yahoo.com> <20210113114531.77e8df2f65a61726c8935dcd@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 13 Jan 2021 11:45:31 +0100
Emmanuel Vadot <manu@bidouilliste.com> wrote:
> On Wed, 13 Jan 2021 10:32:01 +0000 (UTC)
> Filippo Moretti <filippomore@yahoo.com> wrote:
>=20
> > Good morning,=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0 my system:[root@STING /usr/ports/graphics/drm-current-kmod]# u=
name -a
> > FreeBSD STING 13.0-CURRENT FreeBSD 13.0-CURRENT #16 main-c255860-g29036=
06b606: Tue Jan 12 04:59:16 CET 2021=A0=A0=A0=A0 root@STING:/usr/obj/usr/sr=
c/amd64.amd64/sys/STING=A0 amd64
> >=20
> > I get the following error while trying to upgrade drm-current-kmod from=
ports:/usr/ports/graphics/drm-current-kmod/work/drm-kmod-drm_v5.4.62_6/dri=
vers/gpu/drm/amd/amdgpu/amdgpu_device.c:4009:6: error: implicit declaration=
of function 'pci_is_root_bus' is invalid in C99 [-Werror,-Wimplicit-functi=
on-declaration]
> > =A0=A0=A0=A0=A0=A0=A0 if (pci_is_root_bus(adev->pdev->bus)) {
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^
> > /usr/ports/graphics/drm-current-kmod/work/drm-kmod-drm_v5.4.62_6/driver=
s/gpu/drm/amd/amdgpu/amdgpu_device.c:4009:6: note: did you mean 'pci_set_bu=
s'?
> > /usr/src/sys/dev/pci/pcivar.h:385:1: note: 'pci_set_bus' declared here
> > PCI_ACCESSOR(bus,=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 BUS,=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0 uint8_t)
> > ^
> > /usr/src/sys/dev/pci/pcivar.h:371:2: note: expanded from macro 'PCI_ACC=
ESSOR'
> > =A0=A0=A0=A0=A0=A0=A0 __BUS_ACCESSOR(pci, var, PCI, ivar, type)
> > =A0=A0=A0=A0=A0=A0=A0 ^
> > /usr/src/sys/sys/bus.h:812:22: note: expanded from macro '__BUS_ACCESSO=
R'
> > static __inline void varp ## _set_ ## var(device_t dev, type t)=A0=A0=
=A0=A0=A0=A0=A0=A0 \
> > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^
> > <scratch space>:77:1: note: expanded from here
> > pci_set_bus
> > ^
> > 1 error generated.*** Error code 1
> >=20
> > Stop.
> > make[4]: stopped in /usr/ports/graphics/drm-current-kmod/work/drm-kmod-=
drm_v5.4.62_6/amd/amdgpu
> > *** Error code 1
> > *** Error code 1
> > *** Error code 1
> >=20
> > Stop.
> > make[1]: stopped in /usr/ports/graphics/drm-current-kmod
> > *** Error code 1
> >=20
> > Stop.
> > make: stopped in /usr/ports/graphics/drm-current-kmod
> >=20
> > Filippo
> > _______________________________________________
> > freebsd-current@freebsd.org mailing list
> > https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.o=
rg"
>=20
> Sorry that's my fault.
> https://github.com/freebsd/drm-kmod/blob/master/linuxkpi/gplv2/include/li=
nux/pci.h#L121
>=20
> This if 0 should have been #if __FreeBSD_version < 1300135
> I'll check if I've missed more and update the port.
> In the meantime either update your kernel after commit
> 35a39dc5b34962081eeda8dbcf0b99a31585499b or wait that I fix this.
Fixed in r561457.
--=20
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210113122251.b6d35bca0f20ae276dc13018>