Date: Sat, 24 Jan 2004 20:34:00 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Jeff Roberson <jroberson@chesapeake.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/vm vm_zeroidle.c src/sys/kern kern_condvar.c kern_idle.c kern_intr.c kern_mutex.c kern_poll.c kern_shutdown.c kern_sig.c kern_subr.c kern_synch.c Message-ID: <Pine.BSF.4.21.0401242032110.57161-100000@InterJet.elischer.org> In-Reply-To: <20040124225618.W36463-100000@mail.chesapeake.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Jan 2004, Jeff Roberson wrote: > On Sat, 24 Jan 2004, Jeff Roberson wrote: > > > jeff 2004/01/24 19:54:52 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/sys proc.h > > sys/vm vm_zeroidle.c > > sys/kern kern_condvar.c kern_idle.c kern_intr.c > > kern_mutex.c kern_poll.c kern_shutdown.c > > kern_sig.c kern_subr.c kern_synch.c > > kern_thread.c sched_ule.c subr_trap.c > > subr_turnstile.c > > Log: > > - Add a flags parameter to mi_switch. The value of flags may be SW_VOL or > > SW_INVOL. Assert that one of these is set in mi_switch() and propery > > adjust the rusage statistics. This is to simplify the large number of > > users of this interface which were previously all required to adjust the > > proper counter prior to calling mi_switch(). This also facilitates more > > switch and locking optimizations. > > - Change all callers of mi_switch() to pass the appropriate paramter and > > remove direct references to the process statistics. > > I'm usually not a fan of interfaces with lots of flags to modify their > behavior, but I do believe this was a useful thing that a lot of people > were leaning towards for various reasons. jhb and I were discussing adding a flag to do exactly this.. it will allow some other optimisations as well I think.. > > I wasn't certain that the style of the flag deinitions in sys/proc.h was > correct, but it followed other style present in that file. If anyone has > any objections feel free to educate me. > > Thanks, > Jeff > > > > > Revision Changes Path > > 1.45 +3 -6 src/sys/kern/kern_condvar.c > > 1.36 +1 -2 src/sys/kern/kern_idle.c > > 1.105 +2 -4 src/sys/kern/kern_intr.c > > 1.135 +1 -2 src/sys/kern/kern_mutex.c > > 1.16 +1 -2 src/sys/kern/kern_poll.c > > 1.148 +4 -2 src/sys/kern/kern_shutdown.c > > 1.267 +2 -4 src/sys/kern/kern_sig.c > > 1.79 +1 -2 src/sys/kern/kern_subr.c > > 1.238 +10 -7 src/sys/kern/kern_synch.c > > 1.169 +2 -4 src/sys/kern/kern_thread.c > > 1.95 +1 -2 src/sys/kern/sched_ule.c > > 1.262 +1 -2 src/sys/kern/subr_trap.c > > 1.138 +1 -2 src/sys/kern/subr_turnstile.c > > 1.365 +4 -1 src/sys/sys/proc.h > > 1.22 +1 -2 src/sys/vm/vm_zeroidle.c > > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0401242032110.57161-100000>