Date: Fri, 22 Apr 2016 05:52:40 +0000 (UTC) From: Garrett Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298451 - head/usr.sbin/bsnmpd/tools/libbsnmptools Message-ID: <201604220552.u3M5qeku097609@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Fri Apr 22 05:52:40 2016 New Revision: 298451 URL: https://svnweb.freebsd.org/changeset/base/298451 Log: Don't use `entry` after free in the "already in lists" case Return with 0 as it isn't an error. MFC after: 1 week CID: 1006085 Reported by: Coverity Obtained from: Isilon OneFS (part of r493633) Submitted by: Thor Steingrimsson <thor.steingrimsson@isilon.com> Sponsored by: EMC / Isilon Storage Division Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmpimport.c Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmpimport.c ============================================================================== --- head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmpimport.c Fri Apr 22 05:24:15 2016 (r298450) +++ head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmpimport.c Fri Apr 22 05:52:40 2016 (r298451) @@ -693,6 +693,7 @@ snmp_import_table(struct snmp_toolinfo * /* Same entry already present in lists. */ free(entry->string); free(entry); + return (0); } (void) snmp_import_update_table(ENTRY_INDEX, entry);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604220552.u3M5qeku097609>