Date: Fri, 23 Jul 2021 14:03:18 +0200 From: Baptiste Daroussin <bapt@nours.eu> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Adam Weinberger <adamw@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5ff464b1945d - main - bsd.port.mk: Fix typo Message-ID: <20210723120318.bpffo7q7yjbmch27@aniel.nours.eu> In-Reply-To: <YPqvsWHdUzCvEo/O@FreeBSD.org> References: <202107231135.16NBZX7C062107@gitrepo.freebsd.org> <YPqvsWHdUzCvEo/O@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 23, 2021 at 12:01:53PM +0000, Alexey Dokuchaev wrote:
> On Fri, Jul 23, 2021 at 11:35:33AM +0000, Adam Weinberger wrote:
> > commit 5ff464b1945dac6628d87319f6bd1106761b3ba9
> >
> > bsd.port.mk: Fix typo
> >
> > @@ -2246,7 +2246,7 @@ PKG_COMPRESSION_FORMAT?= ${PKG_SUFX:S/.//}
> > .else
> > .if defined(PKG_SUFX)
> > PKG_COMPRESSION_FORMAT?= ${PKG_SUFX:S/.//}
> > -WARNING+= "PKG_SUFX is defined, if should be replaced with PKG_COMPRESSION_FORMAT"
> > +WARNING+= "PKG_SUFX is defined, it should be replaced with PKG_COMPRESSION_FORMAT"
>
> I've also thought that it was a typo and fixed it, but then bapt@ reverted
> this part of the change. You might want to check with him what's going on.
there was a conflict in the rebase and I missed it when solving the conflict.
Sorry about it
Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210723120318.bpffo7q7yjbmch27>