Date: Thu, 23 Feb 2017 23:12:33 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, rik@FreeBSD.org, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r314142 - head/sys/dev/ce Message-ID: <87c0c8ff-e80d-6b6b-a9a7-c3da2ae4da84@FreeBSD.org> In-Reply-To: <20170224030545.GA39731@FreeBSD.org> References: <201702231530.v1NFULwx024028@repo.freebsd.org> <CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com> <d93f402e-d5f5-03c2-3652-2b6f55987288@FreeBSD.org> <20170224030545.GA39731@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, On 2/23/2017 10:05 PM, Alexey Dokuchaev wrote: > On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote: >> On 2/23/2017 12:13 PM, Benjamin Kaduk wrote: >>> On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg@freebsd.org >>> <mailto:pfg@freebsd.org>> wrote: >>> @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) >>> "UserRequest (%s:%d)\n", >>> __FUNCTION__, __LINE__)); >>> return; >>> } >>> - req->Command = TAU32_Configure_Commit | >>> - TAU32_Tx_Stop | TAU32_Rx_Stop; >>> +// req->Command = TAU32_Configure_Commit | >>> +// TAU32_Tx_Stop | TAU32_Rx_Stop; >>> >>> Should probably stick to C-style comments, though. >> They are valid C99 comments but I understand what you mean, > Using comments (regardless of style) for disabling a code block is wrong; > may I suggest `#if 0' instead? (This also does not hurt `svn blame'.) This is not covered by style(9) so I guess it's personal choice. As I see it, '#if 0' is WIP: code that is not ready but is kept to be enabled at later time. I would generally prefer to remove such code and hunt it back through svn if I need it. In this case the code is only to serve as a reference, JIC someone wants to implement it for real. Since the main comment starts with "XXXRIK: .." and states "it is VERY BUGGY!!! Do not use it ... ", I just don't think it is worth to spend much time deciding how to comment it out. Let me CC rik@ though, maybe he has a real fix ;). Pedro. ps. for Roman ... we are discussing this change: https://svnweb.freebsd.org/changeset/base/314142 Feel free to chime in if you have a cleaner workaround.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87c0c8ff-e80d-6b6b-a9a7-c3da2ae4da84>