Date: Sat, 30 Jun 2007 14:47:22 +0200 (CEST) From: Ulrich Spoerlein <uspoerlein@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Warner Losh <imp@FreeBSD.org> Subject: usb/114154: [PATCH] umass quirk: Samsung YP-U2 USB MP3/Ogg Player Message-ID: <200706301247.l5UClMUY008744@roadrunner.q.local> Resent-Message-ID: <200706301250.l5UCo43k035690@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 114154
>Category: usb
>Synopsis: [PATCH] umass quirk: Samsung YP-U2 USB MP3/Ogg Player
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-usb
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Jun 30 12:50:03 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Ulrich Spoerlein
>Release: FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
>Description:
Samsung, YP-U2, 1GB MP3/Ogg Vorbis USB stick fails to attach with the
old USB stack. It works fine with HPS' USB stack, though.
# usbdevs -v
Controller /dev/usb3:
addr 1: high speed, self powered, config 1, EHCI root hub(0x0000), Intel(0x0000), rev 1.00
port 1 addr 8: high speed, power 500 mA, config 1, product 0x5050(0x5050), vendor 0x04e8(0x04e8), rev 10.01
# camcontrol inquiry da0
pass0: <Samsung YP-U2 0100> Removable Direct Access SCSI-4 device
pass0: Serial Number 4002F9D69D94469B
40.000MB/s transfers
# dmesg, no quirk
umass0: <Samsung YP-U2, class 0/0, rev 2.00/10.01, addr 8> on uhub3
umass0: SCSI over Bulk-Only; quirks = 0x0000
umass0:1:0:-1: Attached to scbus1
umass0: BBB reset failed, TIMEOUT
umass0: BBB bulk-in clear stall failed, TIMEOUT
umass0: BBB bulk-out clear stall failed, IOERROR
umass0: BBB reset failed, IOERROR
umass0: BBB bulk-in clear stall failed, IOERROR
umass0: BBB bulk-out clear stall failed, IOERROR
umass0: BBB reset failed, IOERROR
umass0: BBB bulk-in clear stall failed, IOERROR
umass0: BBB bulk-out clear stall failed, IOERROR
umass0: BBB reset failed, IOERROR
umass0: BBB bulk-in clear stall failed, IOERROR
umass0: BBB bulk-out clear stall failed, IOERROR
umass0: BBB reset failed, IOERROR
umass0: BBB bulk-in clear stall failed, IOERROR
umass0: BBB bulk-out clear stall failed, IOERROR
# dmesg, quirk
umass0: <Samsung YP-U2, class 0/0, rev 2.00/10.01, addr 8> on uhub3
umass0: SCSI over Bulk-Only; quirks = 0x0110
umass0:1:0:-1: Attached to scbus1
da0 at umass-sim0 bus 0 target 0 lun 0
da0: <Samsung YP-U2 0100> Removable Direct Access SCSI-4 device
da0: 40.000MB/s transfers
da0: 999MB (511616 2048 byte sectors: 64H 32S/T 249C)
GEOM_LABEL: Label for provider da0s1 is msdosfs/USBSTICK.
>How-To-Repeat:
>Fix:
Index: dev/usb/umass.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v
retrieving revision 1.153
diff -u -p -r1.153 umass.c
--- dev/usb/umass.c 21 Jun 2007 20:13:07 -0000 1.153
+++ dev/usb/umass.c 30 Jun 2007 12:40:14 -0000
@@ -452,6 +452,10 @@ static struct umass_devdescr_t umass_dev
UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
IGNORE_RESIDUE | NO_START_STOP
},
+ { USB_VENDOR_SAMSUNG, USB_PRODUCT_SAMSUNG_YP_U2, RID_WILDCARD,
+ UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
+ SHUTTLE_INIT | NO_GETMAXLUN
+ },
{ USB_VENDOR_SANDISK, USB_PRODUCT_SANDISK_SDDR31, RID_WILDCARD,
UMASS_PROTO_SCSI | UMASS_PROTO_BBB,
READ_CAPACITY_OFFBY1
Index: dev/usb/usbdevs
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/usbdevs,v
retrieving revision 1.311
diff -u -p -r1.311 usbdevs
--- dev/usb/usbdevs 26 Jun 2007 05:29:27 -0000 1.311
+++ dev/usb/usbdevs 30 Jun 2007 12:40:14 -0000
@@ -1752,6 +1752,7 @@ product SAGEM USBSERIAL 0x0027 USB-Seri
/* Samsung products */
product SAMSUNG ML6060 0x3008 ML-6060 laser printer
+product SAMSUNG YP_U2 0x5050 YP-U2 MP3 Player
product SAMSUNG I500 0x6601 I500 Palm USB Phone
/* SanDisk products */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706301247.l5UClMUY008744>