Date: Thu, 25 Jul 2019 12:35:03 -0600 From: Ian Lepore <ian@freebsd.org> To: Larry Rosenman <ler@FreeBSD.org>, Alan Somers <asomers@freebsd.org> Cc: Freebsd current <freebsd-current@freebsd.org> Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build Message-ID: <b9a8de4aa909e5b37465a69eea3f43edee49c07e.camel@freebsd.org> In-Reply-To: <cf768fc3bd626abc24f07fbd55d23938@FreeBSD.org> References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> <ac682e59ecc576fa5bd41a7015505624@FreeBSD.org> <CAOtMX2hqcjn1FOgCNXmnRdvNkpbqnoGDdn9zpHVo4iir_19-GQ@mail.gmail.com> <cf768fc3bd626abc24f07fbd55d23938@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2019-07-25 at 13:13 -0500, Larry Rosenman wrote: > On 07/25/2019 1:10 pm, Alan Somers wrote: > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman <ler@freebsd.org> > > wrote: > > > > > > Um.... Who broke this? > > > > > > /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared > > > identifier > > > 'false' > > > return (false); > > > ^ > > > [...] > > > > > "svn blame" suggests r350199 by kib. However, refcount.h should > > only > > be included if lsof defines _KERNEL, which normal programs > > shouldn't. > > So I think this should be considered a bug in lsof. > > -Alan > > > we *HAVE* to define _KERNEL, to get at the kernel structures..... Then you have to follow the rules (from style(9))... If either <sys/types.h> or <sys/param.h> is needed, include it before other include files. (<sys/param.h> includes <sys/types.h>; do not include both.) Typically, if you're including anything from sys/ you'll need sys/types.h first. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b9a8de4aa909e5b37465a69eea3f43edee49c07e.camel>