Date: Sat, 18 Apr 2026 15:25:48 -0400 From: "Drew Gallatin" <gallatin@freebsd.org> To: tuexen <tuexen@freebsd.org> Cc: current@freebsd.org, "Ricardo Branco" <rbranco@suse.de>, freebsd-current@freebsd.org Subject: Re: panic: assertion failed in iflib_txq_drain() Message-ID: <432c4416-4783-4c7e-8e64-4b440672a355@app.fastmail.com> In-Reply-To: <F1633197-E1FC-413B-82AE-2A1D9FB6B979@FreeBSD.org> References: <9d640ae4-7133-4d4f-917f-d715ab71ee7b@suse.de> <aeNz1A3RtqruU_Ys@albert.catwhisker.org> <EC59DE6A-BD57-4213-948D-F41885CF7AEC@FreeBSD.org> <aeO7-Io1WMKhriEu@albert.catwhisker.org> <F7BF6DA9-2AB5-4438-BB9F-9D3378911561@FreeBSD.org> <3b60c3e6-f53f-4084-a435-fe5371c56e58@app.fastmail.com> <F1633197-E1FC-413B-82AE-2A1D9FB6B979@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Indeed, that looks reasonable, and I see how the packet count was overloaded before. Testing it now. Drew On Sat, Apr 18, 2026, at 3:12 PM, Michael Tuexen wrote: > > On 18. Apr 2026, at 21:09, Drew Gallatin <gallatin@freebsd.org> wrote: > > > > Sorry, looking into this now. I did not test this change with the mp_ring path.. i don't see how fixing the counters could cause this panic. Looking at it now.. > Hi Drew, > > I think https://reviews.freebsd.org/D56509 fixes it. > > Best regards > Michael > > > > Drew > > > > On Sat, Apr 18, 2026, at 1:38 PM, Michael Tuexen wrote: > >> > >> > >> > On 18. Apr 2026, at 19:14, David Wolfskill <david@catwhisker.org> wrote: > >> > > >> > On Sat, Apr 18, 2026 at 03:53:33PM +0200, Michael Tuexen wrote: > >> >> ... > >> >>> So... one of the machines on which I track head got this, as well -- my > >> >>> (mostly-)headless build machine. (2 laptops, updated in sync with the > >> >>> build machine, did not panic. One of those also uses a wired NIC.) > >> >> Do the network drivers of the machines not being affected use iflib? > >> > > >> > Apparently not -- they are em(4), iwm(4), & iwn(4), while the panicking > >> > machine uses igb(4). > >> > > >> >> I do see the problem also on one of my machines and local testing shows that > >> >> https://cgit.FreeBSD.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404 <https://cgit.freebsd.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404>; > >> >> is the problem. At least reverting it locally resolves the problem. > >> >> Can you confirm this? > >> > > >> > I can, and do: after reverting main-n285140-3fade68cfdf9 & rebuilding, > >> > I am able to ssh in without issue; the machine reports: > >> > > >> > freebeast(16.0-C)[2] uname -aUK > >> > FreeBSD freebeast.catwhisker.org 16.0-CURRENT FreeBSD 16.0-CURRENT #549 main-n285180-23a84efeb191: Sat Apr 18 17:01:25 UTC 2026 root@freebeast.catwhisker.org:/common/S3/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1600015 1600015 > >> > > >> > Thanks! > >> You could also disable TSO. I will put up a review for a fix soon. > >> > >> Best regards > >> Michael > >> > > >> > Peace, > >> > david > >> > -- > >> > David H. Wolfskill david@catwhisker.org > >> > > >> > See https://www.catwhisker.org/~david/publickey.gpg for my public key. > >> > >> > >> > > > > [-- Attachment #2 --] <!DOCTYPE html><html><head><title></title></head><body><div>Indeed, that looks reasonable, and I see how the packet count was overloaded before. Testing it now.</div><div><br></div><div>Drew</div><div><br></div><div>On Sat, Apr 18, 2026, at 3:12 PM, Michael Tuexen wrote:</div><blockquote type="cite" id="qt" style=""><div>> On 18. Apr 2026, at 21:09, Drew Gallatin <<a href="mailto:gallatin@freebsd.org">gallatin@freebsd.org</a>> wrote:</div><div>> </div><div>> Sorry, looking into this now. I did not test this change with the mp_ring path.. i don't see how fixing the counters could cause this panic. Looking at it now..</div><div>Hi Drew,</div><div><br></div><div>I think <a href="https://reviews.freebsd.org/D56509">https://reviews.freebsd.org/D56509</a>; fixes it.</div><div><br></div><div>Best regards</div><div>Michael</div><div>> </div><div>> Drew</div><div>> </div><div>> On Sat, Apr 18, 2026, at 1:38 PM, Michael Tuexen wrote:</div><div>>> </div><div>>> </div><div>>> > On 18. Apr 2026, at 19:14, David Wolfskill <<a href="mailto:david@catwhisker.org">david@catwhisker.org</a>> wrote:</div><div>>> > </div><div>>> > On Sat, Apr 18, 2026 at 03:53:33PM +0200, Michael Tuexen wrote:</div><div>>> >> ...</div><div>>> >>> So... one of the machines on which I track head got this, as well -- my</div><div>>> >>> (mostly-)headless build machine. (2 laptops, updated in sync with the</div><div>>> >>> build machine, did not panic. One of those also uses a wired NIC.)</div><div>>> >> Do the network drivers of the machines not being affected use iflib?</div><div>>> > </div><div>>> > Apparently not -- they are em(4), iwm(4), & iwn(4), while the panicking</div><div>>> > machine uses igb(4).</div><div>>> > </div><div>>> >> I do see the problem also on one of my machines and local testing shows that</div><div>>> >> <a href="https://cgit.FreeBSD.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404">https://cgit.FreeBSD.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404</a>; <<a href="https://cgit.freebsd.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404">https://cgit.freebsd.org/src/commit/?id=3fade68cfdf95ee0b517b5d69b270bd8da633404</a>></div><div>>> >> is the problem. At least reverting it locally resolves the problem.</div><div>>> >> Can you confirm this?</div><div>>> > </div><div>>> > I can, and do: after reverting main-n285140-3fade68cfdf9 & rebuilding,</div><div>>> > I am able to ssh in without issue; the machine reports:</div><div>>> > </div><div>>> > freebeast(16.0-C)[2] uname -aUK</div><div>>> > FreeBSD <a href="http://freebeast.catwhisker.org">freebeast.catwhisker.org</a>; 16.0-CURRENT FreeBSD 16.0-CURRENT #549 main-n285180-23a84efeb191: Sat Apr 18 17:01:25 UTC 2026 <a href="mailto:root@freebeast.catwhisker.org">root@freebeast.catwhisker.org</a>:/common/S3/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1600015 1600015</div><div>>> > </div><div>>> > Thanks!</div><div>>> You could also disable TSO. I will put up a review for a fix soon.</div><div>>> </div><div>>> Best regards</div><div>>> Michael</div><div>>> > </div><div>>> > Peace,</div><div>>> > david</div><div>>> > -- </div><div>>> > David H. Wolfskill <a href="mailto:david@catwhisker.org">david@catwhisker.org</a></div><div>>> > </div><div>>> > See <a href="https://www.catwhisker.org/~david/publickey.gpg">https://www.catwhisker.org/~david/publickey.gpg</a>; for my public key.</div><div>>> </div><div>>> </div><div>>> </div><div>> </div><div><br></div><div><br></div></blockquote><div><br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?432c4416-4783-4c7e-8e64-4b440672a355>