Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 11 Dec 2017 22:55:51 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r326783 - head/sys/dev/syscon
Message-ID:  <201712112255.vBBMtpuO098278@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Mon Dec 11 22:55:51 2017
New Revision: 326783
URL: https://svnweb.freebsd.org/changeset/base/326783

Log:
  Correct a typo in syscon driver 'modify' logic
  
  Not previously caught because the current consumer (not yet in tree) doesn't
  use the 'modify' bits (yet).
  
  Reported by:	rpokala

Modified:
  head/sys/dev/syscon/syscon.c

Modified: head/sys/dev/syscon/syscon.c
==============================================================================
--- head/sys/dev/syscon/syscon.c	Mon Dec 11 20:47:26 2017	(r326782)
+++ head/sys/dev/syscon/syscon.c	Mon Dec 11 22:55:51 2017	(r326783)
@@ -104,7 +104,7 @@ syscon_modify_4(device_t dev,  device_t consumer, bus_
 	SYSCON_LOCK(sc);
 	val = bus_read_4(sc->mem_res, offset);
 	val &= ~clear_bits;
-	val |= ~set_bits;
+	val |= set_bits;
 	bus_write_4(sc->mem_res, offset, val);
 	SYSCON_UNLOCK(sc);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712112255.vBBMtpuO098278>