Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 31 Oct 2017 05:11:55 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r325213 - projects/runtime-coverage/tests/tools
Message-ID:  <201710310511.v9V5BtJu074693@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Tue Oct 31 05:11:55 2017
New Revision: 325213
URL: https://svnweb.freebsd.org/changeset/base/325213

Log:
  Polish up end-user messages

Modified:
  projects/runtime-coverage/tests/tools/gather_coverage.sh

Modified: projects/runtime-coverage/tests/tools/gather_coverage.sh
==============================================================================
--- projects/runtime-coverage/tests/tools/gather_coverage.sh	Tue Oct 31 05:04:03 2017	(r325212)
+++ projects/runtime-coverage/tests/tools/gather_coverage.sh	Tue Oct 31 05:11:55 2017	(r325213)
@@ -35,7 +35,7 @@ SCRIPT=${0##*/}
 
 error()
 {
-	printf >&2 "${SCRIPT}: ERROR: $@\n"
+	printf >&2 "${SCRIPT}: ERROR: %s\n" "$@"
 }
 
 require_command()
@@ -45,7 +45,7 @@ require_command()
 	if ! command -v $cmd >/dev/null; then
 		error "required command not found: $cmd"
 		if [ $# -gt 0 ]; then
-			printf >&2 "$@\n"
+			printf >&2 "%s\n" "$@"
 		fi
 		exit 1
 	fi
@@ -54,13 +54,13 @@ require_command()
 
 
 require_command ${GCOV} \
-    "Install gcov from base or the appropriate version from ports"
+    'Install gcov from base, or specify alternate version, e.g., from ports, using $GCOV.'
 for cmd in lcov genhtml; do
-	require_command ${cmd} "Install devel/lcov from ports"
+	require_command ${cmd} "Install devel/lcov from ports."
 done
 
 if ! COVERAGE_TMP=$(mktemp -d tmp.XXXXXX); then
-	error "failed to create COVERAGE_TMP"
+	error "failed to create COVERAGE_TMP."
 	exit 1
 fi
 trap "rm -Rf '$COVERAGE_TMP'" EXIT INT TERM



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201710310511.v9V5BtJu074693>