Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Feb 2025 16:00:31 +0800
From:      Po-Chuan Hsieh <sunpoet@freebsd.org>
To:        "Jason E. Hale" <jhale@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: c0f5e78bc53d - main - */Makefile: Sort SUBDIRs
Message-ID:  <CAMHz58Q9qHadrosUu0pbb8-JjFtC19G=1M8DVA%2BRPLiBW5ov%2BA@mail.gmail.com>
In-Reply-To: <CAJE75NEL_kFP1%2Bfy8S7bhniJSt6sNmTv2m67cuyCOQ_peMJy4A@mail.gmail.com>
References:  <202502200500.51K50Usp000920@gitrepo.freebsd.org> <CAJE75NEL_kFP1%2Bfy8S7bhniJSt6sNmTv2m67cuyCOQ_peMJy4A@mail.gmail.com>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Thu, Feb 20, 2025 at 2:14 PM Jason E. Hale <jhale@freebsd.org> wrote:

> On Thu, Feb 20, 2025 at 12:00 AM Po-Chuan Hsieh <sunpoet@freebsd.org>
> wrote:
> >
> > The branch main has been updated by sunpoet:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=c0f5e78bc53d64667736fc0598b86916c0baa6cd
> >
> > commit c0f5e78bc53d64667736fc0598b86916c0baa6cd
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2025-02-20 05:00:19 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2025-02-20 05:00:19 +0000
> >
> >     */Makefile: Sort SUBDIRs
> > ---
> >  audio/Makefile    | 2 +-
> >  graphics/Makefile | 6 +++---
> >  net/Makefile      | 2 +-
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/audio/Makefile b/audio/Makefile
> > index 4fe6a57143c1..b3ab52f478fd 100644
> > --- a/audio/Makefile
> > +++ b/audio/Makefile
> > @@ -419,8 +419,8 @@
> >      SUBDIR += linux-rl9-opus
> >      SUBDIR += linux-rl9-pulseaudio-libs
> >      SUBDIR += linux-rl9-pulseaudio-utils
> > -    SUBDIR += linux-rl9-sdl_sound
> >      SUBDIR += linux-rl9-sdl2_mixer
> > +    SUBDIR += linux-rl9-sdl_sound
> >      SUBDIR += linuxsampler
> >      SUBDIR += linuxwave
> >      SUBDIR += liquidsfz
> > diff --git a/graphics/Makefile b/graphics/Makefile
> > index 5ef6add378a7..8f64a5344ada 100644
> > --- a/graphics/Makefile
> > +++ b/graphics/Makefile
> > @@ -561,12 +561,12 @@
> >      SUBDIR += linux-rl9-qt5-qtimageformats
> >      SUBDIR += linux-rl9-qt5-qtsvg
> >      SUBDIR += linux-rl9-qt5-qtwayland
> > -    SUBDIR += linux-rl9-sdl_gfx
> > -    SUBDIR += linux-rl9-sdl_image
> > -    SUBDIR += linux-rl9-sdl_ttf
> >      SUBDIR += linux-rl9-sdl2_gfx
> >      SUBDIR += linux-rl9-sdl2_image
> >      SUBDIR += linux-rl9-sdl2_ttf
> > +    SUBDIR += linux-rl9-sdl_gfx
> > +    SUBDIR += linux-rl9-sdl_image
> > +    SUBDIR += linux-rl9-sdl_ttf
> >      SUBDIR += linux-rl9-shaderc
> >      SUBDIR += linux-rl9-spirv-tools
> >      SUBDIR += linux-rl9-tiff
> > diff --git a/net/Makefile b/net/Makefile
> > index e4b74debacdf..114a89b17d9c 100644
> > --- a/net/Makefile
> > +++ b/net/Makefile
> > @@ -450,8 +450,8 @@
> >      SUBDIR += linux-rl9-avahi-libs
> >      SUBDIR += linux-rl9-libproxy
> >      SUBDIR += linux-rl9-openldap
> > -    SUBDIR += linux-rl9-sdl_net
> >      SUBDIR += linux-rl9-sdl2_net
> > +    SUBDIR += linux-rl9-sdl_net
> >      SUBDIR += linux-rl9-tcp_wrappers-libs
> >      SUBDIR += liveMedia
> >      SUBDIR += lla
>
> This looks wrong. sort(1) sorts those entries the way they were. Even
> ls(1) lists them in that order.
>
> - Jason
>

The default LANG/LC_ALL is C.
Please see Mk/bsd.port.mk (around line 996 to 998).

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr">On Thu, Feb 20, 2025 at 2:14 PM Jason E. Hale &lt;<a href="mailto:jhale@freebsd.org">jhale@freebsd.org</a>&gt; wrote:<br></div><div class="gmail_quote gmail_quote_container"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Feb 20, 2025 at 12:00 AM Po-Chuan Hsieh &lt;<a href="mailto:sunpoet@freebsd.org" target="_blank">sunpoet@freebsd.org</a>&gt; wrote:<br>
&gt;<br>
&gt; The branch main has been updated by sunpoet:<br>
&gt;<br>
&gt; URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=c0f5e78bc53d64667736fc0598b86916c0baa6cd" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=c0f5e78bc53d64667736fc0598b86916c0baa6cd</a><br>;
&gt;<br>
&gt; commit c0f5e78bc53d64667736fc0598b86916c0baa6cd<br>
&gt; Author:     Po-Chuan Hsieh &lt;sunpoet@FreeBSD.org&gt;<br>
&gt; AuthorDate: 2025-02-20 05:00:19 +0000<br>
&gt; Commit:     Po-Chuan Hsieh &lt;sunpoet@FreeBSD.org&gt;<br>
&gt; CommitDate: 2025-02-20 05:00:19 +0000<br>
&gt;<br>
&gt;     */Makefile: Sort SUBDIRs<br>
&gt; ---<br>
&gt;  audio/Makefile    | 2 +-<br>
&gt;  graphics/Makefile | 6 +++---<br>
&gt;  net/Makefile      | 2 +-<br>
&gt;  3 files changed, 5 insertions(+), 5 deletions(-)<br>
&gt;<br>
&gt; diff --git a/audio/Makefile b/audio/Makefile<br>
&gt; index 4fe6a57143c1..b3ab52f478fd 100644<br>
&gt; --- a/audio/Makefile<br>
&gt; +++ b/audio/Makefile<br>
&gt; @@ -419,8 +419,8 @@<br>
&gt;      SUBDIR += linux-rl9-opus<br>
&gt;      SUBDIR += linux-rl9-pulseaudio-libs<br>
&gt;      SUBDIR += linux-rl9-pulseaudio-utils<br>
&gt; -    SUBDIR += linux-rl9-sdl_sound<br>
&gt;      SUBDIR += linux-rl9-sdl2_mixer<br>
&gt; +    SUBDIR += linux-rl9-sdl_sound<br>
&gt;      SUBDIR += linuxsampler<br>
&gt;      SUBDIR += linuxwave<br>
&gt;      SUBDIR += liquidsfz<br>
&gt; diff --git a/graphics/Makefile b/graphics/Makefile<br>
&gt; index 5ef6add378a7..8f64a5344ada 100644<br>
&gt; --- a/graphics/Makefile<br>
&gt; +++ b/graphics/Makefile<br>
&gt; @@ -561,12 +561,12 @@<br>
&gt;      SUBDIR += linux-rl9-qt5-qtimageformats<br>
&gt;      SUBDIR += linux-rl9-qt5-qtsvg<br>
&gt;      SUBDIR += linux-rl9-qt5-qtwayland<br>
&gt; -    SUBDIR += linux-rl9-sdl_gfx<br>
&gt; -    SUBDIR += linux-rl9-sdl_image<br>
&gt; -    SUBDIR += linux-rl9-sdl_ttf<br>
&gt;      SUBDIR += linux-rl9-sdl2_gfx<br>
&gt;      SUBDIR += linux-rl9-sdl2_image<br>
&gt;      SUBDIR += linux-rl9-sdl2_ttf<br>
&gt; +    SUBDIR += linux-rl9-sdl_gfx<br>
&gt; +    SUBDIR += linux-rl9-sdl_image<br>
&gt; +    SUBDIR += linux-rl9-sdl_ttf<br>
&gt;      SUBDIR += linux-rl9-shaderc<br>
&gt;      SUBDIR += linux-rl9-spirv-tools<br>
&gt;      SUBDIR += linux-rl9-tiff<br>
&gt; diff --git a/net/Makefile b/net/Makefile<br>
&gt; index e4b74debacdf..114a89b17d9c 100644<br>
&gt; --- a/net/Makefile<br>
&gt; +++ b/net/Makefile<br>
&gt; @@ -450,8 +450,8 @@<br>
&gt;      SUBDIR += linux-rl9-avahi-libs<br>
&gt;      SUBDIR += linux-rl9-libproxy<br>
&gt;      SUBDIR += linux-rl9-openldap<br>
&gt; -    SUBDIR += linux-rl9-sdl_net<br>
&gt;      SUBDIR += linux-rl9-sdl2_net<br>
&gt; +    SUBDIR += linux-rl9-sdl_net<br>
&gt;      SUBDIR += linux-rl9-tcp_wrappers-libs<br>
&gt;      SUBDIR += liveMedia<br>
&gt;      SUBDIR += lla<br>
<br>
This looks wrong. sort(1) sorts those entries the way they were. Even<br>
ls(1) lists them in that order.<br>
<br>
- Jason<br></blockquote><div><br></div><div>The default LANG/LC_ALL is C.<br></div><div>Please see Mk/<a href="http://bsd.port.mk">bsd.port.mk</a>; (around line 996 to 998).</div></div></div>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q9qHadrosUu0pbb8-JjFtC19G=1M8DVA%2BRPLiBW5ov%2BA>