Date: Sat, 17 Apr 2004 18:15:32 -0700 (PDT) From: Luigi Rizzo <luigi@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_arp.h if_ethersubr.c if_fddisubr.c if_iso88025subr.c if_var.h src/sys/netgraph ng_eiface.c ng_ether.c Message-ID: <200404180115.i3I1FXCO079174@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
luigi 2004/04/17 18:15:32 PDT
FreeBSD src repository
Modified files:
sys/net if_arp.h if_ethersubr.c if_fddisubr.c
if_iso88025subr.c if_var.h
sys/netgraph ng_eiface.c ng_ether.c
Log:
+ rename and document an unused field in struct arpcom (field is still
there so there are no ABI changes);
+ replace 5 redefinitions of the IPF2AC macro with one in if_arp.h
Eventually (but before freezing the ABI) we need to get rid of
struct arpcom (initially with the help of some smart #defines
to avoid having to touch each and every driver, see below).
Apart from the struct ifnet, struct arpcom now only stores a copy
of the MAC address (ac_enaddr, but we already have another copy in
the struct ifnet -- if_addrhead), and a netgraph-specific field
which is _always_ accessed through the ifp, so it might well go
into the struct ifnet too (where, besides, there is already an entry
for AF_NETGRAPH data...)
Too bad ac_enaddr is widely referenced by all drivers. But
this can be fixed as follows:
#define ac_enaddr ac_if.the_original_ac_enaddr_in_struct_ifnet
(note that the right hand side would likely be a pointer rather than
the base address of an array.)
Revision Changes Path
1.19 +5 -1 src/sys/net/if_arp.h
1.166 +0 -1 src/sys/net/if_ethersubr.c
1.91 +0 -1 src/sys/net/if_fddisubr.c
1.62 +0 -1 src/sys/net/if_iso88025subr.c
1.72 +4 -0 src/sys/net/if_var.h
1.13 +0 -1 src/sys/netgraph/ng_eiface.c
1.33 +0 -1 src/sys/netgraph/ng_ether.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200404180115.i3I1FXCO079174>